Ref T10319. Adds in database columns for upcoming default generated avatar support.
Details
- Reviewers
epriestley - Maniphest Tasks
- T10319: Generate unique? profile images for each new user
- Commits
- rPf2e013c2e98b: Prep user table for default images
Ran storage upgrade, log into local site to verify it didn't blow up.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I'm not sure I understand why phid? was suggested for nullable, but not imageversion. I imagine we'll only write imageversion when we write a phid.
There's no strong reason not to make version nullable.
The weak reason is that with text-like fields both '' (empty string) and null (null) might be valid values with different meanings, and making text-like fields non-nullable when they aren't meaningful may slightly reduces potential confusion in the future -- you don't have to go check if null and '' mean different things or not. With PHIDs, '' is consistently never valid so there isn't as much of an ambiguity. But I don't think it's really ambiguous here, and EditEngine has reduced how much of a problem this is by getting rid of all the if ($old === null) { ... } stuff around creation transactions, which was the major case where null and '' meant different things.