Page MenuHomePhabricator

Prep user table for default images
ClosedPublic

Authored by chad on Mar 4 2017, 5:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 5:09 AM
Unknown Object (File)
Sat, Dec 7, 2:25 PM
Unknown Object (File)
Thu, Dec 5, 10:46 AM
Unknown Object (File)
Mon, Dec 2, 1:47 PM
Unknown Object (File)
Mon, Dec 2, 1:31 PM
Unknown Object (File)
Wed, Nov 20, 6:42 PM
Unknown Object (File)
Nov 16 2024, 7:20 AM
Unknown Object (File)
Nov 11 2024, 10:19 PM
Subscribers

Details

Summary

Ref T10319. Adds in database columns for upcoming default generated avatar support.

Test Plan

Ran storage upgrade, log into local site to verify it didn't blow up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm not sure I understand why phid? was suggested for nullable, but not imageversion. I imagine we'll only write imageversion when we write a phid.

  • make version nullable

There's no strong reason not to make version nullable.

The weak reason is that with text-like fields both '' (empty string) and null (null) might be valid values with different meanings, and making text-like fields non-nullable when they aren't meaningful may slightly reduces potential confusion in the future -- you don't have to go check if null and '' mean different things or not. With PHIDs, '' is consistently never valid so there isn't as much of an ambiguity. But I don't think it's really ambiguous here, and EditEngine has reduced how much of a problem this is by getting rid of all the if ($old === null) { ... } stuff around creation transactions, which was the major case where null and '' meant different things.

This revision is now accepted and ready to land.Mar 4 2017, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the explanation.