Differential D17440

Add `maniphest.subtypes` for configuring task subtypes
ClosedPublic
Actions

Authored by epriestley on Mar 1 2017, 11:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T12314: Support formal task subtypes (like "bug" vs "feature")

Commits

rP1b96f2fc2870: Add `maniphest.subtypes` for configuring task subtypes

Summary

Ref T12314. Builds toward letting you define "animal" and "plant" tasks.

This just adds some configuration. I'll probably add some more quality-of-life options (like "icon") later but these are the only bits I'm sure I'll need.

Test Plan

Configured sensible subtypes.
Tried to configure bad subtypes: bad key, missing "default", duplicate keys. Got sensible error messages.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley created this revision.Mar 1 2017, 11:24 PM

Harbormaster completed remote builds in B15841: Diff 41937.Mar 1 2017, 11:25 PM

chad accepted this revision.Mar 2 2017, 12:15 AM

This revision is now accepted and ready to land.Mar 2 2017, 12:15 AM

Closed by commit rP1b96f2fc2870: Add `maniphest.subtypes` for configuring task subtypes (authored by epriestley). · Explain WhyMar 2 2017, 12:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/__phutil_library_map__.php (2 lines)
A	M	src/applications/maniphest/config/ManiphestSubtypesConfigOptionsType.php (10 lines)
M		src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php (48 lines)
M		src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php (48 lines)