Differential D17438

Get line count before truncating Paste snippets
ClosedPublic
Actions

Authored by faulconbridge on Mar 1 2017, 9:27 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12338: Paste line counts incorrect if content is more than 1024 characters

Commits

rP5fad7eb1f902: Get line count before truncating Paste snippets

Summary

Fixes T12338. Resolves an issue where long pastes would be truncated before getting a line count, resulting in an inaccurate line count being returned.

Test Plan

Made a large paste, verified that it displayed the correct number of lines.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

faulconbridge created this revision.Mar 1 2017, 9:27 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 1 2017, 9:27 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B15838: Diff 41934.Mar 1 2017, 9:28 PM

epriestley accepted this revision.Mar 1 2017, 10:21 PM

This revision is now accepted and ready to land.Mar 1 2017, 10:21 PM

Closed by commit rP5fad7eb1f902: Get line count before truncating Paste snippets (authored by faulconbridge). · Explain WhyMar 1 2017, 10:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/paste/query/PhabricatorPasteQuery.php (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41934	3f1ee67		Mar 1 2017, 9:27 PM	★	★
Diff 2	41935	3f1ee67	rP5fad7eb1f902abfada18abf655ea991fb9a71a72	Mar 1 2017, 10:30 PM	★	★

Diff 41935

View Options

src/applications/paste/query/PhabricatorPasteQuery.php

Get line count before truncating Paste snippetsClosedPublicActions