Page MenuHomePhabricator

Fix an issue where daemons can stick in a pool
ClosedPublic

Authored by epriestley on Feb 28 2017, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 6:26 PM
Unknown Object (File)
Apr 22 2026, 10:15 AM
Unknown Object (File)
Mar 31 2026, 4:52 AM
Unknown Object (File)
Mar 5 2026, 2:17 PM
Unknown Object (File)
Feb 11 2026, 2:10 AM
Unknown Object (File)
Feb 4 2026, 10:55 AM
Unknown Object (File)
Feb 4 2026, 7:31 AM
Unknown Object (File)
Jan 11 2026, 10:53 AM
Subscribers
None

Details

Summary

Ref T12331. Root problem is the unset($daemon) just unsets a key in a local variable, rather than actually discarding the daemon.

Add some logging to make this more clear and clean up some %d vs %s stuff.

Test Plan
  • Ran a pool with bin/phd debug task --pool N, let it scale up, let it scale down, used bin/worker flood to add more tasks.
  • Before patch, the ghost daemons took up the slots in the pool.
  • After patch, the ghost daemons got removed properly and were replaced with fresh daemons.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/daemon/PhutilDaemonPool.php
181–188

Specifically, this is the actual bugfix.

🤷 ¯\_(ツ)_/¯

This revision is now accepted and ready to land.Feb 28 2017, 4:12 PM
This revision was automatically updated to reflect the committed changes.