Page MenuHomePhabricator

Fix an issue where daemons can stick in a pool
ClosedPublic

Authored by epriestley on Feb 28 2017, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 12:18 PM
Unknown Object (File)
Mon, Jan 27, 10:29 PM
Unknown Object (File)
Fri, Jan 24, 7:24 PM
Unknown Object (File)
Fri, Jan 24, 7:24 PM
Unknown Object (File)
Fri, Jan 24, 7:24 PM
Unknown Object (File)
Thu, Jan 23, 5:38 PM
Unknown Object (File)
Tue, Jan 21, 12:34 PM
Unknown Object (File)
Tue, Jan 21, 6:02 AM
Subscribers
None

Details

Summary

Ref T12331. Root problem is the unset($daemon) just unsets a key in a local variable, rather than actually discarding the daemon.

Add some logging to make this more clear and clean up some %d vs %s stuff.

Test Plan
  • Ran a pool with bin/phd debug task --pool N, let it scale up, let it scale down, used bin/worker flood to add more tasks.
  • Before patch, the ghost daemons took up the slots in the pool.
  • After patch, the ghost daemons got removed properly and were replaced with fresh daemons.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/daemon/PhutilDaemonPool.php
181–188

Specifically, this is the actual bugfix.

🤷 ¯\_(ツ)_/¯

This revision is now accepted and ready to land.Feb 28 2017, 4:12 PM
This revision was automatically updated to reflect the committed changes.