Page MenuHomePhabricator

Fix bad JS rendering in "Allow Desktop Notifications" workflow
ClosedPublic

Authored by epriestley on Feb 20 2017, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:16 AM
Unknown Object (File)
Sun, Apr 7, 12:32 PM
Unknown Object (File)
Wed, Apr 3, 10:46 PM
Unknown Object (File)
Mar 19 2024, 5:55 PM
Unknown Object (File)
Mar 19 2024, 5:55 PM
Unknown Object (File)
Mar 19 2024, 5:55 PM
Unknown Object (File)
Mar 19 2024, 5:55 PM
Unknown Object (File)
Mar 15 2024, 4:56 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.kde.org/T5404. This code was doing some .firstChild shenanigans which didn't survive some UI refactoring.

This whole UI is a little iffy but just unbreak it for now.

Test Plan

Allowed and rejected desktop notifications, got largely reasonable UI rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 20 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.