Page MenuHomePhabricator
Differential D17388

Fix bad JS rendering in "Allow Desktop Notifications" workflow
ClosedPublic
Actions

Authored by epriestley on Feb 20 2017, 8:51 PM.
Tags
None
Referenced Files
F19898016: D17388.id.diff
Sun, Mar 29, 10:08 AM
F19895746: D17388.diff
Sat, Mar 28, 11:36 PM
F19832928: D17388.id.diff
Mar 11 2026, 12:32 AM
F19832922: D17388.id.diff
Mar 11 2026, 12:31 AM
F19801069: D17388.id41812.diff
Feb 28 2026, 8:27 PM
F19565107: D17388.diff
Jan 31 2026, 5:38 PM
F19552843: D17388.diff
Jan 29 2026, 4:14 AM
F19511503: D17388.diff
Jan 12 2026, 3:51 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPab9c1b73b532: Fix bad JS rendering in "Allow Desktop Notifications" workflow
Summary

See downstream https://phabricator.kde.org/T5404. This code was doing some .firstChild shenanigans which didn't survive some UI refactoring.

This whole UI is a little iffy but just unbreak it for now.

Test Plan

Allowed and rejected desktop notifications, got largely reasonable UI rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 20 2017, 8:51 PM
Harbormaster completed remote builds in B15708: Diff 41811.Feb 20 2017, 8:52 PM
chad accepted this revision.Feb 20 2017, 8:52 PM
This revision is now accepted and ready to land.Feb 20 2017, 8:52 PM
Closed by commit rPab9c1b73b532: Fix bad JS rendering in "Allow Desktop Notifications" workflow (authored by epriestley, committed by epriestley). · Explain WhyFeb 20 2017, 8:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
settings/
panel/
12 lines
webroot/
rsrc/
js/
application/
aphlict/
16 lines

Diff 41812

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js

Loading...
Phabricator · Built by Phacility