Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Fri, Feb 17, 5:33 PM.

Details

Test Plan

None.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vrana created this revision.Fri, Feb 17, 5:33 PM
vrana added inline comments.Fri, Feb 17, 5:37 PM
src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

LOL.

vrana added a comment.Fri, Feb 17, 5:38 PM

(These are from PHPStan's level 5 errors.)

epriestley accepted this revision.Fri, Feb 17, 5:46 PM

Good catch! What's the underlying rule that detected that? (Variable assignment without use before next assignment?)

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

Ugh, thanks.

This revision is now accepted and ready to land.Fri, Feb 17, 5:46 PM
vrana added a comment.Sat, Feb 18, 9:22 AM

Comparing a string to false with ===.

This revision was automatically updated to reflect the committed changes.