Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 17 2017, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 7:07 AM
Unknown Object (File)
Wed, Dec 4, 6:48 AM
Unknown Object (File)
Mon, Dec 2, 4:27 PM
Unknown Object (File)
Fri, Nov 29, 3:44 PM
Unknown Object (File)
Wed, Nov 27, 12:09 PM
Unknown Object (File)
Tue, Nov 26, 12:58 AM
Unknown Object (File)
Mon, Nov 25, 4:28 AM
Unknown Object (File)
Thu, Nov 21, 4:11 AM
Subscribers

Details

Test Plan

None.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

LOL.

(These are from PHPStan's level 5 errors.)

Good catch! What's the underlying rule that detected that? (Variable assignment without use before next assignment?)

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

Ugh, thanks.

This revision is now accepted and ready to land.Feb 17 2017, 5:46 PM

Comparing a string to false with ===.

This revision was automatically updated to reflect the committed changes.