Page MenuHomePhabricator
Differential D17377

Fix errors found by PHPStan
ClosedPublic
Actions

Authored by vrana on Feb 17 2017, 5:33 PM.
Tags
None
Referenced Files
F13085256: D17377.diff
Wed, Apr 24, 11:45 PM
Unknown Object (File)
Fri, Apr 19, 6:15 PM
Unknown Object (File)
Thu, Apr 11, 8:01 AM
Unknown Object (File)
Mon, Apr 8, 3:11 AM
Unknown Object (File)
Mon, Apr 1, 4:39 PM
Unknown Object (File)
Sat, Mar 30, 4:00 PM
Unknown Object (File)
Sat, Mar 30, 4:11 AM
Unknown Object (File)
Fri, Mar 29, 3:58 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP9f3cde4db765: Fix errors found by PHPStan
Test Plan

None.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vrana created this revision.Feb 17 2017, 5:33 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 17 2017, 5:33 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B15678: Diff 41783.Feb 17 2017, 5:34 PM
vrana added inline comments.Feb 17 2017, 5:37 PM
src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

LOL.

vrana added a comment.Feb 17 2017, 5:38 PM

(These are from PHPStan's level 5 errors.)

epriestley accepted this revision.Feb 17 2017, 5:46 PM

Good catch! What's the underlying rule that detected that? (Variable assignment without use before next assignment?)

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

Ugh, thanks.

This revision is now accepted and ready to land.Feb 17 2017, 5:46 PM
vrana added a comment.Feb 18 2017, 9:22 AM

Comparing a string to false with ===.

Closed by commit rP9f3cde4db765: Fix errors found by PHPStan (authored by vrana, committed by vrana). · Explain WhyFeb 18 2017, 9:25 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D17460: Fix a constant typo in Diviner ("DECLARATAION" -> "TION").Mar 4 2017, 3:17 PM
epriestley mentioned this in rPd5baf2fe3755: Fix a constant typo in Diviner ("DECLARATAION" -> "TION").Mar 4 2017, 5:54 PM

Revision Contents
Changeset List

Diff 41804

View Options

src/applications/calendar/util/CalendarTimeUtil.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
View Options

src/infrastructure/time/PhabricatorTime.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

src/view/viewutils.php

Loading...
Phabricator · Built by Phacility