Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 17 2017, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 10:52 AM
Unknown Object (File)
Wed, Jan 29, 8:02 AM
Unknown Object (File)
Mon, Jan 27, 6:17 AM
Unknown Object (File)
Sat, Jan 25, 11:11 AM
Unknown Object (File)
Thu, Jan 23, 11:24 PM
Unknown Object (File)
Wed, Jan 22, 11:44 PM
Unknown Object (File)
Wed, Jan 22, 11:00 AM
Unknown Object (File)
Wed, Jan 22, 11:00 AM
Subscribers

Details

Test Plan

None.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

LOL.

(These are from PHPStan's level 5 errors.)

Good catch! What's the underlying rule that detected that? (Variable assignment without use before next assignment?)

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114

Ugh, thanks.

This revision is now accepted and ready to land.Feb 17 2017, 5:46 PM

Comparing a string to false with ===.

This revision was automatically updated to reflect the committed changes.