Differential D17332

Stop "Header" fields (labels for form sections) from trying to generate Conduit edits
ClosedPublic
Actions

Authored by epriestley on Feb 10 2017, 3:14 PM.

Details

Reviewers
chad
Maniphest Tasks
T12236: Conduit Method maniphest.edit: Unhandled Exception
Commits
rP743dc9fdb514: Stop "Header" fields (labels for form sections) from trying to generate Conduit…
Summary

Fixes T12236. Headers are currently trying to generate an edit transaction for maniphest.edit and similar, but should not, since you can't edit them.

Test Plan
  • Configured Maniphest with a custom header field.
  • Before change: maniphest.edit API console page fataled.
  • After change: all good, no weird "header" transaction.
  • Header still shows up on "Edit Task" form in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 10 2017, 3:14 PM
chad accepted this revision.Feb 10 2017, 3:36 PM
This revision is now accepted and ready to land.Feb 10 2017, 3:36 PM
Closed by commit rP743dc9fdb514: Stop "Header" fields (labels for form sections) from trying to generate Conduit… (authored by epriestley). · Explain WhyFeb 10 2017, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 41686

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php

Loading...
Phabricator · Built by Phacility