Differential D17246

Add some sort of sort to Emoji Autocomplete
ClosedPublic
Actions

Authored by chad on Jan 25 2017, 4:16 AM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T12139: Add a proper emoji picker to Remarkup bar

Commits

rP01b35cdc120b: Add some sort of sort to Emoji Autocomplete

Summary

Ref T12139. Adds sorting by shortname. Also I sorted everything else. No reason. It didn't help

Test Plan

:star

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad created this revision.Jan 25 2017, 4:16 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 25 2017, 4:16 AM

Harbormaster completed remote builds in B15369: Diff 41479.Jan 25 2017, 4:17 AM

epriestley accepted this revision.Jan 25 2017, 4:18 AM

epriestley added inline comments.

scripts/celerity/generate_emoji.php
43	I believe this won't impact the display order in the UI, but it will make future `manifest.json` diffs smaller so it's probably good anyway.

This revision is now accepted and ready to land.Jan 25 2017, 4:18 AM

where do you want the ' '

n/m

Closed by commit rP01b35cdc120b: Add some sort of sort to Emoji Autocomplete (authored by chad). · Explain WhyJan 25 2017, 4:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			resources/emoji/manifest.json (2892 lines)
M			scripts/celerity/generate_emoji.php (6 lines)
M			src/applications/macro/typeahead/PhabricatorEmojiDatasource.php (4 lines)

Diff 41480

resources/emoji/manifest.json

Loading...

scripts/celerity/generate_emoji.php

Loading...

src/applications/macro/typeahead/PhabricatorEmojiDatasource.php

Loading...