Page MenuHomePhabricator

Mark fields as required on MenuItems
ClosedPublic

Authored by chad on Jan 19 2017, 9:32 PM.
Tags
None
Referenced Files
F18110600: D17231.id41443.diff
Mon, Aug 11, 9:32 PM
F18104640: D17231.id41444.diff
Sun, Aug 10, 1:33 PM
F18104639: D17231.id41443.diff
Sun, Aug 10, 1:33 PM
F18104638: D17231.id.diff
Sun, Aug 10, 1:33 PM
F18100423: D17231.diff
Sat, Aug 9, 11:53 AM
F18052143: D17231.id.diff
Mon, Aug 4, 1:31 AM
F18032061: D17231.diff
Sun, Aug 3, 12:14 AM
Unknown Object (File)
Jun 15 2025, 1:06 AM
Subscribers

Details

Summary

Mark required fields as required. Though in testing, none of these work.

Test Plan

Try to save a form without an app/project/dashboard and see success (not expected)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This only controls the UI, I can counterdiff you for actual validation logic. I think there's an existing TODO on "Link" items anyway since they have no validation on typing garbage in for the link target, which can be confusing since security code then nukes it on the display side.

This revision is now accepted and ready to land.Jan 19 2017, 9:39 PM
This revision was automatically updated to reflect the committed changes.