Page MenuHomePhabricator

Remove timeline from Profile Manage
ClosedPublic

Authored by chad on Jan 19 2017, 8:57 PM.
Tags
None
Referenced Files
F13096557: D17230.diff
Thu, Apr 25, 5:20 PM
Unknown Object (File)
Mon, Apr 22, 3:24 AM
Unknown Object (File)
Tue, Apr 2, 6:28 PM
Unknown Object (File)
Mon, Apr 1, 7:04 PM
Unknown Object (File)
Mar 20 2024, 6:25 AM
Unknown Object (File)
Mar 20 2024, 6:24 AM
Unknown Object (File)
Mar 20 2024, 6:24 AM
Unknown Object (File)
Feb 19 2024, 2:57 AM
Subscribers

Details

Summary

Not sure this page is really providing any value, the timeline always says "edited this object" and there is a list of actions. Seems we could move actions back to the profile proper, but they feel very... engineery to me. Or we could fix the timeline stories, but my guess is they aren't useful or we would have gotten such feedback.

Test Plan

Review manage page, timeline is gone. Page is clean.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'd like to fix this timeline to show administrative events, particularly account disables/enables. This information is indirectly available in People > Activity Logs but inconvenient to access. However, I can put the timeline back after I fix it.

This revision is now accepted and ready to land.Jan 19 2017, 9:01 PM

I’m guessing that’s not something I could do?

This revision was automatically updated to reflect the committed changes.

You could, but it's enough work that I don't think it's worthwhile until we do a general update here (maybe related to generally improving logging/security stuff?), since "Disable / Enable" isn't transactional right now.

You could fix the feed as it exists today by adding rendering methods to the stuff in src/applications/people/customfield/, I think -- they're missing getApplicationTransactionTitle() methods, mostly. That would get us "epriestley changed titles from X to Y" instead of "epriestley edited this object.", at least.