Page MenuHomePhabricator

Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state
ClosedPublic

Authored by epriestley on Jan 18 2017, 9:01 PM.
Tags
None
Referenced Files
F18840143: D17226.diff
Mon, Oct 27, 9:37 PM
F18838788: D17226.id41434.diff
Mon, Oct 27, 12:26 PM
F18816319: D17226.id41430.diff
Tue, Oct 21, 6:00 AM
F18816136: D17226.id.diff
Tue, Oct 21, 5:08 AM
F18809422: D17226.diff
Sun, Oct 19, 1:49 PM
F18807199: D17226.id.diff
Sat, Oct 18, 11:47 PM
F18804179: D17226.diff
Sat, Oct 18, 6:39 AM
F18798641: D17226.diff
Fri, Oct 17, 7:23 AM
Subscribers
None

Details

Summary

To set this up:

  • alice accepts a revision.
  • Something adds a package or project she has authority over as a reviewer.
  • Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).
Test Plan
  • Created a revision.
  • Accepted as user "dog".
  • Added "dog project".
  • Re-accepted.
  • Could not three-accept.
  • Removed "dog project.
  • Rejected.
  • Added "dog project".
  • Re-rejected.
  • Could not three-reject.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable