Page MenuHomePhabricator

Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state
ClosedPublic

Authored by epriestley on Jan 18 2017, 9:01 PM.
Tags
None
Referenced Files
F19814191: D17226.id41434.diff
Wed, Mar 4, 12:52 PM
F19808716: D17226.diff
Tue, Mar 3, 7:10 AM
F19613674: D17226.id41430.diff
Feb 3 2026, 9:12 PM
F18853745: D17226.diff
Oct 31 2025, 7:13 PM
F18840143: D17226.diff
Oct 27 2025, 9:37 PM
F18838788: D17226.id41434.diff
Oct 27 2025, 12:26 PM
F18816319: D17226.id41430.diff
Oct 21 2025, 6:00 AM
F18816136: D17226.id.diff
Oct 21 2025, 5:08 AM
Subscribers
None

Details

Summary

To set this up:

  • alice accepts a revision.
  • Something adds a package or project she has authority over as a reviewer.
  • Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).
Test Plan
  • Created a revision.
  • Accepted as user "dog".
  • Added "dog project".
  • Re-accepted.
  • Could not three-accept.
  • Removed "dog project.
  • Rejected.
  • Added "dog project".
  • Re-rejected.
  • Could not three-reject.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable