Page MenuHomePhabricator

Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state
ClosedPublic

Authored by epriestley on Jan 18 2017, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 23, 3:10 AM
Unknown Object (File)
Wed, Nov 23, 3:09 AM
Unknown Object (File)
Wed, Nov 23, 3:09 AM
Unknown Object (File)
Mon, Nov 14, 5:54 AM
Unknown Object (File)
Fri, Nov 11, 11:11 PM
Unknown Object (File)
Fri, Nov 11, 8:11 AM
Unknown Object (File)
Fri, Nov 11, 8:11 AM
Unknown Object (File)
Fri, Nov 11, 8:10 AM
Subscribers
None

Details

Summary

To set this up:

  • alice accepts a revision.
  • Something adds a package or project she has authority over as a reviewer.
  • Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).
Test Plan
  • Created a revision.
  • Accepted as user "dog".
  • Added "dog project".
  • Re-accepted.
  • Could not three-accept.
  • Removed "dog project.
  • Rejected.
  • Added "dog project".
  • Re-rejected.
  • Could not three-reject.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable