Page MenuHomePhabricator

Merge "Audit" more completely into "Diffusion"
ClosedPublic

Authored by epriestley on Jan 11 2017, 11:20 PM.

Details

Summary

Fixes T6630. Long ago, "Audit", "Diffusion" and "Repositories" were three totally separate applications.

This separation isn't useful and the three rapidly became intertwined. Ideally, they would all be one application.

This doesn't take us quite that far, but Audit no longer has any controllers and has little actual behavior.

The "Audit" screen has always just been a SearchEngine view of commits with some filters on it, and this formalizes that and puts a link to it in Diffusion. (This view has other uses, too.)

Test Plan
  • Accessed audit from home page.
  • Accessed audit/commits from Diffusion.
  • Could no longer uninstall Audit on its own.
  • Grepped for /audit/ and AuditApplication.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 11 2017, 11:43 PM
This revision was automatically updated to reflect the committed changes.