Ref T11957, builds out /home/menu/ as a basic structure for adding/editing the homepage menu.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11957: Add MenuEngine to Home
- Commits
- rPdfee1352e98a: Basic structure for MenuItem on Home
visit /home/menu/ and add items to global and personal. Not wired to anything.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/home/constants/PhabricatorHomeConstants.php | ||
---|---|---|
7–17 | Instead of hard-coding these, you should add (or reuse) methods on PhabricatorApplication so each application, so the code looks something like this: foreach ($all_applications as $app) { if ($app->shouldThisThingGoOnTheDefaultHomeMenu()) { $items[] = new item } } Then third-party applications will be able to install themselves, etc. I think isPinnedByDefault() is currently the method for this. You can generate builtin keys like "app.".$app->getPHID() or similar. They just need to be unique; they don't need to be constants. |