Straighten out some stacked action removal behaviors
ClosedPublic
Actions

Authored by epriestley on Jan 5 2017, 3:15 AM.

Tags

None

Referenced Files

	F15398023: D17143.id41229.diff
	Sun, Mar 16, 11:10 PM

	F15395483: D17143.id.diff
	Sun, Mar 16, 7:18 AM

	F15343183: D17143.id41229.diff
	Sun, Mar 9, 10:14 PM

	Unknown Object (File)
	Fri, Feb 21, 3:01 PM

	Unknown Object (File)
	Tue, Feb 18, 10:38 AM

	Unknown Object (File)
	Feb 13 2025, 3:08 AM

	Unknown Object (File)
	Feb 7 2025, 3:37 AM

	Unknown Object (File)
	Feb 2 2025, 2:34 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12065: Can't close actions in Maniphest

Commits

rP4b94ae15e0bc: Straighten out some stacked action removal behaviors

Summary

Fixes T12065. Some of the normal behavior of these actions got juggled when I made "Accept" and "Reject" conflict.

Test Plan

Added "Accept".
Added "Reject", saw it remove "Accept".
Added "Change Projects".
Added "Assign/Claim".
Removed "Assign/Claim".
Removed "Accept".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 5 2017, 3:15 AM

chad accepted this revision.Jan 5 2017, 3:16 AM

This revision is now accepted and ready to land.Jan 5 2017, 3:16 AM

Harbormaster completed remote builds in B15112: Diff 41229.Jan 5 2017, 3:16 AM

Closed by commit rP4b94ae15e0bc: Straighten out some stacked action removal behaviors (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2017, 3:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

6 lines

Diff 41230

View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Straighten out some stacked action removal behaviorsClosedPublicActions