Straighten out some stacked action removal behaviors
ClosedPublic
Actions

Authored by epriestley on Jan 5 2017, 3:15 AM.

Tags

None

Referenced Files

	F13180288: D17143.diff
	Wed, May 8, 11:00 PM

	Unknown Object (File)
	Sat, May 4, 7:54 PM

	Unknown Object (File)
	Wed, May 1, 12:13 AM

	Unknown Object (File)
	Sun, Apr 28, 11:59 AM

	Unknown Object (File)
	Wed, Apr 24, 6:33 AM

	Unknown Object (File)
	Wed, Apr 24, 6:20 AM

	Unknown Object (File)
	Mon, Apr 22, 1:17 PM

	Unknown Object (File)
	Fri, Apr 19, 6:01 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12065: Can't close actions in Maniphest

Commits

rP4b94ae15e0bc: Straighten out some stacked action removal behaviors

Summary

Fixes T12065. Some of the normal behavior of these actions got juggled when I made "Accept" and "Reject" conflict.

Test Plan

Added "Accept".
Added "Reject", saw it remove "Accept".
Added "Change Projects".
Added "Assign/Claim".
Removed "Assign/Claim".
Removed "Accept".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 5 2017, 3:15 AM

chad accepted this revision.Jan 5 2017, 3:16 AM

This revision is now accepted and ready to land.Jan 5 2017, 3:16 AM

Harbormaster completed remote builds in B15112: Diff 41229.Jan 5 2017, 3:16 AM

Closed by commit rP4b94ae15e0bc: Straighten out some stacked action removal behaviors (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2017, 3:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

6 lines

Diff 41230

View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Straighten out some stacked action removal behaviorsClosedPublicActions