Page MenuHomePhabricator

Apply application visibility checks during normal object filtering
ClosedPublic

Authored by epriestley on Jan 1 2017, 7:10 PM.
Tags
None
Referenced Files
F22117933: D17127.diff
Sat, Aug 22, 3:54 AM
Unknown Object (File)
Feb 12 2026, 1:25 AM
Unknown Object (File)
Feb 10 2026, 10:42 PM
Unknown Object (File)
Jan 31 2026, 2:48 PM
Unknown Object (File)
Dec 27 2025, 10:07 PM
Unknown Object (File)
Nov 28 2025, 1:00 PM
Unknown Object (File)
Oct 31 2025, 12:39 PM
Unknown Object (File)
Oct 27 2025, 12:45 PM
Subscribers
None

Details

Summary

Fixes T9058. Normally, "Query" classes apply an application check and just don't load anything if it fails.

However, in some cases (like email recipient filtering) we run policy checks without having run a Query check first. In that case, one user (the actor) loads the object, then we filter it against other users (the recipeints).

Explicitly apply the application check during normal filtering.

Test Plan

Added a failing test case and made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 1:10 AM
This revision was automatically updated to reflect the committed changes.