Page MenuHomePhabricator

Apply application visibility checks during normal object filtering
ClosedPublic

Authored by epriestley on Jan 1 2017, 7:10 PM.
Tags
None
Referenced Files
F15574593: D17127.diff
Tue, May 6, 2:16 AM
F15542368: D17127.id.diff
Fri, Apr 25, 4:37 PM
F15537646: D17127.diff
Thu, Apr 24, 2:51 PM
F15513485: D17127.id.diff
Thu, Apr 17, 7:17 PM
F15508172: D17127.id41194.diff
Wed, Apr 16, 2:42 AM
F15492237: D17127.id.diff
Sat, Apr 12, 12:39 PM
F15489848: D17127.diff
Fri, Apr 11, 12:42 PM
F15470955: D17127.id41189.diff
Apr 5 2025, 2:18 AM
Subscribers
None

Details

Summary

Fixes T9058. Normally, "Query" classes apply an application check and just don't load anything if it fails.

However, in some cases (like email recipient filtering) we run policy checks without having run a Query check first. In that case, one user (the actor) loads the object, then we filter it against other users (the recipeints).

Explicitly apply the application check during normal filtering.

Test Plan

Added a failing test case and made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 1:10 AM
This revision was automatically updated to reflect the committed changes.