Page MenuHomePhabricator

Apply application visibility checks during normal object filtering
ClosedPublic

Authored by epriestley on Jan 1 2017, 7:10 PM.
Tags
None
Referenced Files
F15404685: D17127.id41194.diff
Tue, Mar 18, 8:38 AM
F15398435: D17127.id41194.diff
Mon, Mar 17, 12:06 AM
F15398434: D17127.id41189.diff
Mon, Mar 17, 12:06 AM
F15398056: D17127.id41189.diff
Sun, Mar 16, 11:13 PM
F15377310: D17127.id41194.diff
Thu, Mar 13, 8:35 AM
F15321414: D17127.id41194.diff
Thu, Mar 6, 10:57 PM
Unknown Object (File)
Fri, Feb 21, 3:00 PM
Unknown Object (File)
Feb 9 2025, 3:04 AM
Subscribers
None

Details

Summary

Fixes T9058. Normally, "Query" classes apply an application check and just don't load anything if it fails.

However, in some cases (like email recipient filtering) we run policy checks without having run a Query check first. In that case, one user (the actor) loads the object, then we filter it against other users (the recipeints).

Explicitly apply the application check during normal filtering.

Test Plan

Added a failing test case and made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 1:10 AM
This revision was automatically updated to reflect the committed changes.