Page MenuHomePhabricator

Apply application visibility checks during normal object filtering
ClosedPublic

Authored by epriestley on Jan 1 2017, 7:10 PM.
Tags
None
Referenced Files
F14061398: D17127.diff
Mon, Nov 18, 6:29 AM
F14048993: D17127.diff
Thu, Nov 14, 10:36 AM
F14034291: D17127.diff
Sat, Nov 9, 11:28 PM
F14020606: D17127.diff
Wed, Nov 6, 12:56 AM
F13991206: D17127.id.diff
Tue, Oct 22, 9:17 AM
F13985289: D17127.id41194.diff
Sun, Oct 20, 7:27 PM
F13973623: D17127.id41189.diff
Oct 18 2024, 1:48 AM
F13963266: D17127.diff
Oct 15 2024, 2:58 PM
Subscribers
None

Details

Summary

Fixes T9058. Normally, "Query" classes apply an application check and just don't load anything if it fails.

However, in some cases (like email recipient filtering) we run policy checks without having run a Query check first. In that case, one user (the actor) loads the object, then we filter it against other users (the recipeints).

Explicitly apply the application check during normal filtering.

Test Plan

Added a failing test case and made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 1:10 AM
This revision was automatically updated to reflect the committed changes.