Page MenuHomePhabricator

Fix a ModularTransactions exception with custom fields that support change details
ClosedPublic

Authored by epriestley on Dec 14 2016, 1:53 AM.
Tags
None
Referenced Files
F18791402: D17051.id41012.diff
Thu, Oct 16, 12:05 PM
F18771402: D17051.id.diff
Wed, Oct 8, 7:28 PM
F18594187: D17051.id.diff
Sep 12 2025, 5:20 PM
F18594091: D17051.id41016.diff
Sep 12 2025, 4:58 PM
F18591773: D17051.id41016.diff
Sep 12 2025, 10:06 AM
F18587529: D17051.id.diff
Sep 11 2025, 9:42 PM
F18098944: D17051.id41016.diff
Aug 9 2025, 12:03 AM
F18091521: D17051.id.diff
Aug 6 2025, 10:20 PM
Subscribers
None

Details

Summary

We're throwing here when we actually want to return null so we make it into custom field handling code. See Conpherence.

Test Plan

Found a failing task and re-executed it with bin/worker execute --id <id>; after this change, it didn't fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a ModularTransactions exception with custom fields that support change details.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 1:53 AM
This revision was automatically updated to reflect the committed changes.