Page MenuHomePhabricator

Fix a ModularTransactions exception with custom fields that support change details
ClosedPublic

Authored by epriestley on Dec 14 2016, 1:53 AM.
Tags
None
Referenced Files
F18947524: D17051.id.diff
Tue, Nov 11, 9:58 PM
F18871824: D17051.diff
Wed, Nov 5, 12:44 AM
F18854275: D17051.id41012.diff
Fri, Oct 31, 10:59 PM
F18849738: D17051.id41016.diff
Thu, Oct 30, 11:54 AM
F18791402: D17051.id41012.diff
Oct 16 2025, 12:05 PM
F18771402: D17051.id.diff
Oct 8 2025, 7:28 PM
F18594187: D17051.id.diff
Sep 12 2025, 5:20 PM
F18594091: D17051.id41016.diff
Sep 12 2025, 4:58 PM
Subscribers
None

Details

Summary

We're throwing here when we actually want to return null so we make it into custom field handling code. See Conpherence.

Test Plan

Found a failing task and re-executed it with bin/worker execute --id <id>; after this change, it didn't fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a ModularTransactions exception with custom fields that support change details.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 1:53 AM
This revision was automatically updated to reflect the committed changes.