Page MenuHomePhabricator

Fix a ModularTransactions exception with custom fields that support change details
ClosedPublic

Authored by epriestley on Dec 14 2016, 1:53 AM.
Tags
None
Referenced Files
F15429092: D17051.id.diff
Mon, Mar 24, 12:33 AM
F15429035: D17051.id41012.diff
Mon, Mar 24, 12:05 AM
F15428949: D17051.id.diff
Sun, Mar 23, 11:39 PM
F15422449: D17051.diff
Sat, Mar 22, 8:28 AM
F15407262: D17051.id41012.diff
Tue, Mar 18, 4:34 PM
F15398357: D17051.id.diff
Mon, Mar 17, 12:02 AM
F15390428: D17051.id41012.diff
Sat, Mar 15, 6:12 AM
Unknown Object (File)
Tue, Feb 25, 3:26 AM
Subscribers
None

Details

Summary

We're throwing here when we actually want to return null so we make it into custom field handling code. See Conpherence.

Test Plan

Found a failing task and re-executed it with bin/worker execute --id <id>; after this change, it didn't fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a ModularTransactions exception with custom fields that support change details.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 1:53 AM
This revision was automatically updated to reflect the committed changes.