Page MenuHomePhabricator
Differential D17041

Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
ClosedPublic
Actions

Authored by epriestley on Dec 13 2016, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 2:10 AM
Unknown Object (File)
Tue, Jan 28, 2:10 AM
Unknown Object (File)
Tue, Jan 28, 2:10 AM
Unknown Object (File)
Sat, Jan 25, 2:23 PM
Unknown Object (File)
Fri, Jan 24, 6:31 PM
Unknown Object (File)
Fri, Jan 24, 6:30 PM
Unknown Object (File)
Fri, Jan 24, 6:30 PM
Unknown Object (File)
Wed, Jan 22, 5:50 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10967: Move Differential reviewers back to a dedicated database storage table
Commits
rP77fa1ea73835: Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
Summary

Ref T10967. This makes room for a DifferentialReviewer object which can be a real storage table.

Test Plan

Grepped for DifferentialReviewer, browsed Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40992.Dec 13 2016, 6:17 PM
epriestley retitled this revision from to Rename "DifferentialReviewer" to "DifferentialReviewerProxy".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10967: Move Differential reviewers back to a dedicated database storage table.
chad accepted this revision.Dec 13 2016, 6:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 6:24 PM
Closed by commit rP77fa1ea73835: Rename "DifferentialReviewer" to "DifferentialReviewerProxy" (authored by epriestley, committed by epriestley). · Explain WhyDec 13 2016, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41005

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewer.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewerProxy.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
Phabricator · Built by Phacility