Page MenuHomePhabricator

Move timeline anchor targets up to evade a Chrome 55 behavioral change
ClosedPublic

Authored by epriestley on Dec 12 2016, 6:36 PM.
Tags
None
Referenced Files
F14036072: D17033.id40974.diff
Sun, Nov 10, 8:27 AM
F14032085: D17033.diff
Sat, Nov 9, 12:44 PM
F14013522: D17033.id40974.diff
Sat, Nov 2, 7:31 AM
F14013044: D17033.id.diff
Fri, Nov 1, 11:47 PM
F13997089: D17033.id.diff
Thu, Oct 24, 2:02 AM
F13986656: D17033.diff
Mon, Oct 21, 4:34 AM
F13981189: D17033.id40974.diff
Sat, Oct 19, 2:48 PM
Unknown Object (File)
Oct 8 2024, 1:57 AM
Subscribers
None

Details

Summary

Fixes T11997. This lifts the targets out of the containing overflow: hidden; div so Chrome is willing to target them.

Test Plan

In Chrome, visited direct comment links and ended up in the right place. Clicked comment anchors, saw browser jump around again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move timeline anchor targets up to evade a Chrome 55 behavioral change.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 6:38 PM
This revision was automatically updated to reflect the committed changes.