Page MenuHomePhabricator

Move timeline anchor targets up to evade a Chrome 55 behavioral change
ClosedPublic

Authored by epriestley on Dec 12 2016, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 8:27 AM
Unknown Object (File)
Sat, Nov 9, 12:44 PM
Unknown Object (File)
Sat, Nov 2, 7:31 AM
Unknown Object (File)
Fri, Nov 1, 11:47 PM
Unknown Object (File)
Thu, Oct 24, 2:02 AM
Unknown Object (File)
Oct 21 2024, 4:34 AM
Unknown Object (File)
Oct 19 2024, 2:48 PM
Unknown Object (File)
Oct 8 2024, 1:57 AM
Subscribers
None

Details

Summary

Fixes T11997. This lifts the targets out of the containing overflow: hidden; div so Chrome is willing to target them.

Test Plan

In Chrome, visited direct comment links and ended up in the right place. Clicked comment anchors, saw browser jump around again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move timeline anchor targets up to evade a Chrome 55 behavioral change.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 6:38 PM
This revision was automatically updated to reflect the committed changes.