Fix two overzealous renames of getPanelKey()
ClosedPublic
Actions

Authored by epriestley on Dec 12 2016, 6:16 PM.

Tags

None

Referenced Files

	F14056442: D17032.diff
	Sat, Nov 16, 8:38 PM

	F13996845: D17032.diff
	Thu, Oct 24, 12:27 AM

	F13996676: D17032.diff
	Wed, Oct 23, 11:03 PM

	F13972495: D17032.id40972.diff
	Oct 17 2024, 7:19 PM

	Unknown Object (File)
	Sep 21 2024, 1:24 AM

	Unknown Object (File)
	Sep 20 2024, 2:38 PM

	Unknown Object (File)
	Sep 20 2024, 1:22 PM

	Unknown Object (File)
	Sep 20 2024, 1:19 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11999: Fatal on "Customize Menu..." on home

Commits

rP8e0d936f72c7: Fix two overzealous renames of getPanelKey()

Summary

Fixes T11999. These are actual panels (SettingsPanel) which are panelley so it's OK.

Test Plan

Clicked "Customize Menu..." on Home.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40971.Dec 12 2016, 6:16 PM

epriestley retitled this revision from to Fix two overzealous renames of getPanelKey().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11999: Fatal on "Customize Menu..." on home.

chad accepted this revision.Dec 12 2016, 6:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2016, 6:17 PM

Closed by commit rP8e0d936f72c7: Fix two overzealous renames of getPanelKey() (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2016, 6:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsMainController.php

4 lines

Diff 40972

View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

Fix two overzealous renames of getPanelKey()ClosedPublicActions