Page MenuHomePhabricator
Differential D17032

Fix two overzealous renames of getPanelKey()
ClosedPublic
Actions

Authored by epriestley on Dec 12 2016, 6:16 PM.
Tags
None
Referenced Files
F18956456: D17032.id.diff
Wed, Nov 12, 10:15 PM
F18846445: D17032.diff
Oct 29 2025, 6:55 PM
F18811654: D17032.id.diff
Oct 20 2025, 4:08 AM
F18790604: D17032.diff
Oct 15 2025, 3:52 PM
F18763401: D17032.id.diff
Oct 7 2025, 12:04 AM
F18758797: D17032.diff
Oct 5 2025, 11:43 PM
F18748366: D17032.id40971.diff
Oct 3 2025, 8:58 PM
F18501948: D17032.id.diff
Sep 4 2025, 10:04 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11999: Fatal on "Customize Menu..." on home
Commits
rP8e0d936f72c7: Fix two overzealous renames of getPanelKey()
Summary

Fixes T11999. These are actual panels (SettingsPanel) which are panelley so it's OK.

Test Plan

Clicked "Customize Menu..." on Home.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40971.Dec 12 2016, 6:16 PM
epriestley retitled this revision from to Fix two overzealous renames of getPanelKey().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11999: Fatal on "Customize Menu..." on home.
chad accepted this revision.Dec 12 2016, 6:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 6:17 PM
Closed by commit rP8e0d936f72c7: Fix two overzealous renames of getPanelKey() (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2016, 6:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
controller/
4 lines

Diff 40972

View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...
Phabricator · Built by Phacility