Differential D17031

Restrict hover styles in action list to only href
ClosedPublic
Actions

Authored by chad on Dec 12 2016, 5:06 PM.

Details

Reviewers

epriestley

Commits

rPa79e4b786ea3: Restrict hover styles in action list to only href

Summary

We're currently applying these styles to labels, restrict them to only list elements that have an href.

Test Plan

Test a label, an anchor, and a button as an action item.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40968.Dec 12 2016, 5:06 PM

chad retitled this revision from to Restrict hover styles in action list to only href.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2016, 5:06 PM

epriestley accepted this revision.Dec 12 2016, 5:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2016, 5:06 PM

Closed by commit rPa79e4b786ea3: Restrict hover styles in action list to only href (authored by chad, committed by chad). · Explain WhyDec 12 2016, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

view/

layout/

PhabricatorActionView.php

4 lines

webroot/

rsrc/

css/

phui/

phui-two-column-view.css

4 lines

Diff 40970

View Options

resources/celerity/map.php

View Options

src/view/layout/PhabricatorActionView.php

View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Restrict hover styles in action list to only hrefClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40970

resources/celerity/map.php

src/view/layout/PhabricatorActionView.php

webroot/rsrc/css/phui/phui-two-column-view.css

Restrict hover styles in action list to only href
ClosedPublic
Actions

Revision Contents
Changeset List