Page MenuHomePhabricator

Fix some form layout issues in settings
ClosedPublic

Authored by chad on Dec 7 2016, 5:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 12:34 PM
Unknown Object (File)
Thu, Dec 12, 1:51 AM
Unknown Object (File)
Wed, Dec 11, 11:46 PM
Unknown Object (File)
Sat, Dec 7, 7:24 PM
Unknown Object (File)
Sat, Dec 7, 5:06 PM
Unknown Object (File)
Mon, Dec 2, 4:18 PM
Unknown Object (File)
Sat, Nov 30, 2:33 PM
Unknown Object (File)
Wed, Nov 27, 1:59 AM
Subscribers

Details

Summary

Form inputs with just text or certain selects had extra space. This uses better text centering.

Test Plan

Review forms on all Settings pages, Custom Policy, Herald.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Fix some form layout issues in settings.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

By the way, I really like that PHUIInfoView tweak you did a while back. Error messages are far more pleasant now.

This revision is now accepted and ready to land.Dec 7 2016, 8:53 PM
This revision was automatically updated to reflect the committed changes.