Page MenuHomePhabricator

Use proper file icons in lightbox
ClosedPublic

Authored by chad on Nov 28 2016, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:55 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Sat, Mar 30, 4:44 AM
Unknown Object (File)
Feb 17 2024, 4:53 PM
Unknown Object (File)
Feb 16 2024, 3:39 PM
Unknown Object (File)
Feb 14 2024, 5:27 PM
Unknown Object (File)
Feb 8 2024, 5:39 AM
Unknown Object (File)
Feb 3 2024, 1:14 PM
Subscribers

Details

Summary

Ref T3612. Passes in file size and file icon for non-images.

Test Plan

Review a PDF and PSD in a lightbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Use proper file icons in lightbox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.

Add "services/src/" to your "load-libraries" config to clear that test failure, I think?

epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 7:19 PM

I refuse to conform to your "rules".

This revision was automatically updated to reflect the committed changes.