Page MenuHomePhabricator

Use proper file icons in lightbox
ClosedPublic

Authored by chad on Nov 28 2016, 7:16 PM.

Details

Summary

Ref T3612. Passes in file size and file icon for non-images.

Test Plan

Review a PDF and PSD in a lightbox.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 40810.Nov 28 2016, 7:16 PM
chad retitled this revision from to Use proper file icons in lightbox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
epriestley edited edge metadata.Nov 28 2016, 7:19 PM

Add "services/src/" to your "load-libraries" config to clear that test failure, I think?

epriestley accepted this revision.Nov 28 2016, 7:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 7:19 PM
chad added a comment.Nov 28 2016, 7:29 PM

I refuse to conform to your "rules".

This revision was automatically updated to reflect the committed changes.