Page MenuHomePhabricator
Differential D16957

Use proper file icons in lightbox
ClosedPublic
Actions

Authored by chad on Nov 28 2016, 7:16 PM.
Tags
None
Referenced Files
F14051313: D16957.diff
Thu, Nov 14, 11:46 PM
F14037884: D16957.diff
Sun, Nov 10, 7:47 PM
F14022855: D16957.diff
Wed, Nov 6, 8:08 PM
F13976681: D16957.diff
Fri, Oct 18, 3:17 PM
F13975340: D16957.diff
Fri, Oct 18, 9:45 AM
F13955070: D16957.diff
Oct 14 2024, 12:04 AM
Unknown Object (File)
Oct 2 2024, 12:10 AM
Unknown Object (File)
Sep 20 2024, 11:59 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP80570d668bb3: Use proper file icons in lightbox
Summary

Ref T3612. Passes in file size and file icon for non-images.

Test Plan

Review a PDF and PSD in a lightbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40810.Nov 28 2016, 7:16 PM
chad retitled this revision from to Use proper file icons in lightbox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2016, 7:16 PM
epriestley edited edge metadata.Nov 28 2016, 7:19 PM

Add "services/src/" to your "load-libraries" config to clear that test failure, I think?

epriestley accepted this revision.Nov 28 2016, 7:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 7:19 PM
chad added a comment.Nov 28 2016, 7:29 PM

I refuse to conform to your "rules".

Closed by commit rP80570d668bb3: Use proper file icons in lightbox (authored by chad, committed by chad). · Explain WhyNov 28 2016, 7:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
layout/
13 lines
webroot/
rsrc/
js/
core/
2 lines

Diff 40811

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorFileLinkView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility