Page MenuHomePhabricator

Allow `bin/storage adjust` to adjust table engines
ClosedPublic

Authored by epriestley on Nov 24 2016, 5:08 PM.
Tags
None
Referenced Files
F15581711: D16941.id40785.diff
Wed, May 7, 12:38 PM
F15556854: D16941.id40785.diff
Mon, Apr 28, 6:44 PM
F15554496: D16941.id40774.diff
Mon, Apr 28, 7:22 AM
F15547934: D16941.id.diff
Sat, Apr 26, 8:47 PM
F15541036: D16941.diff
Fri, Apr 25, 10:18 AM
F15488676: D16941.id40774.diff
Fri, Apr 11, 1:15 AM
F15439192: D16941.id40785.diff
Mar 26 2025, 6:15 AM
F15438104: D16941.id.diff
Mar 25 2025, 11:23 PM
Subscribers
None

Details

Summary

Ref T11741. On recent-enough versions of MySQL, we would prefer to use InnoDB for fulltext indexes instead of MyISAM.

Allow bin/storage adjust to read actual and expected table engines, and apply adjustments as necessary.

We have one existing bad table that uses the wrong engine, metamta_applicationemail. This change corrects that table.

Test Plan
  • Ran bin/storage upgrade.
  • Saw the adjustment phase apply this change properly:
>>>[463] <query> ALTER TABLE `local_metamta`.`metamta_applicationemail` COLLATE = 'utf8mb4_bin', ENGINE = 'InnoDB'

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow `bin/storage adjust` to adjust table engines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 5:18 PM
This revision was automatically updated to reflect the committed changes.