Page MenuHomePhabricator

Allow `bin/storage adjust` to adjust table engines
ClosedPublic

Authored by epriestley on Nov 24 2016, 5:08 PM.
Tags
None
Referenced Files
F19502302: D16941.id40785.diff
Thu, Jan 8, 3:58 PM
F19072182: D16941.id.diff
Nov 30 2025, 9:39 PM
F19060844: D16941.diff
Nov 29 2025, 10:28 AM
F18843375: D16941.id.diff
Oct 28 2025, 9:40 PM
F18838531: D16941.diff
Oct 27 2025, 11:18 AM
F18817343: D16941.id40774.diff
Oct 21 2025, 2:44 PM
F18788917: D16941.id40785.diff
Oct 15 2025, 7:05 AM
F18650017: D16941.id40774.diff
Sep 20 2025, 11:06 PM
Subscribers
None

Details

Summary

Ref T11741. On recent-enough versions of MySQL, we would prefer to use InnoDB for fulltext indexes instead of MyISAM.

Allow bin/storage adjust to read actual and expected table engines, and apply adjustments as necessary.

We have one existing bad table that uses the wrong engine, metamta_applicationemail. This change corrects that table.

Test Plan
  • Ran bin/storage upgrade.
  • Saw the adjustment phase apply this change properly:
>>>[463] <query> ALTER TABLE `local_metamta`.`metamta_applicationemail` COLLATE = 'utf8mb4_bin', ENGINE = 'InnoDB'

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow `bin/storage adjust` to adjust table engines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 5:18 PM
This revision was automatically updated to reflect the committed changes.