Page MenuHomePhabricator
Differential D16940

Create and populate a stopwords table for InnoDB fulltext indexes to use in the future
ClosedPublic
Actions

Authored by epriestley on Nov 24 2016, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:55 PM
Unknown Object (File)
Thu, Apr 4, 7:34 PM
Unknown Object (File)
Thu, Apr 4, 7:34 PM
Unknown Object (File)
Thu, Apr 4, 7:34 PM
Unknown Object (File)
Wed, Mar 27, 8:43 PM
Unknown Object (File)
Wed, Mar 27, 3:23 PM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
Unknown Object (File)
Mar 10 2024, 3:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud)
Commits
rPff3333548f8a: Create and populate a stopwords table for InnoDB fulltext indexes to use in the…
Summary

Ref T11741. InnoDB uses a stopwords table instead of a stopwords file.

During storage upgrade, synchronize the table from the stopwords file on disk.

Test Plan
  • Ran storage upgrade.
  • Ran select * from stopwords, saw stopwords.
  • Added some garbage to the table.
  • Ran storage upgrade, saw it remove it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40773.Nov 24 2016, 4:43 PM
epriestley retitled this revision from to Create and populate a stopwords table for InnoDB fulltext indexes to use in the future.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a task: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
epriestley added a reviewer: chad.Nov 24 2016, 6:32 PM

We don't actually end up really needing this since the InnoDB stopwords are pretty reasonable, but I wrote it and it could make things easier in the future (e.g., it lets us tell users to change one setting to enable it). If it creates any maintenance headaches I'll just throw it out.

chad accepted this revision.Nov 24 2016, 6:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 6:53 PM
Closed by commit rPff3333548f8a: Create and populate a stopwords table for InnoDB fulltext indexes to use in the… (authored by epriestley, committed by epriestley). · Explain WhyNov 25 2016, 11:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
3 lines
src/
applications/
search/
storage/
8 lines
document/
2 lines
infrastructure/
storage/
management/
workflow/
53 lines

Diff 40784

View Options

resources/sql/autopatches/20161124.search.01.stopwords.sql

Loading...
View Options

src/applications/search/storage/PhabricatorSearchSchemaSpec.php

Loading...
View Options

src/applications/search/storage/document/PhabricatorSearchDocument.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php

Loading...
Phabricator · Built by Phacility