Page MenuHomePhabricator
Differential D16929

Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 7:38 AM
Unknown Object (File)
Mon, Nov 18, 9:45 AM
Unknown Object (File)
Wed, Nov 13, 9:40 PM
Unknown Object (File)
Sun, Nov 10, 1:11 AM
Unknown Object (File)
Wed, Nov 6, 7:01 AM
Unknown Object (File)
Wed, Oct 30, 4:02 PM
Unknown Object (File)
Oct 9 2024, 6:18 AM
Unknown Object (File)
Oct 1 2024, 4:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rARCd00de495bcf5: Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc…
Summary

Ref T10895. Currently, the "browse as a commit" code does these lookups, but the code can't be reused.

For T10895, I want to introduce "browse as revision", but it will need to do the same ref lookup. Separate this as a hardpoint so the code can be shared via hardpoint/ref infrastructure.

Test Plan

Ran arc browse master and similar commands.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40750.Nov 23 2016, 5:49 PM
epriestley retitled this revision from to Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
chad accepted this revision.Nov 23 2016, 5:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:50 PM
Closed by commit rARCd00de495bcf5: Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc… (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40761

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitURIHardpointLoader.php

Loading...
View Options

src/browse/ref/ArcanistBrowseRef.php

Loading...
View Options

src/loader/ArcanistCommitUpstreamHardpointLoader.php

Loading...
View Options

src/loader/ArcanistHardpointLoader.php

Loading...
View Options

src/ref/ArcanistCommitRef.php

Loading...
Phabricator · Built by Phacility