Page MenuHomePhabricator

Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow
ClosedPublic

Authored by epriestley on Nov 23 2016, 5:49 PM.
Tags
None
Referenced Files
F10892271: D16929.id40761.diff
Sun, Jul 3, 5:45 PM
F10892270: D16929.id40750.diff
Sun, Jul 3, 5:44 PM
F10892269: D16929.id.diff
Sun, Jul 3, 5:44 PM
F10892268: D16929.diff
Sun, Jul 3, 5:44 PM
Unknown Object (File)
Sun, Jun 26, 3:06 PM
Unknown Object (File)
Thu, Jun 16, 10:53 AM
Unknown Object (File)
Sun, Jun 12, 10:07 AM
Unknown Object (File)
May 24 2022, 3:54 AM
Subscribers
None

Details

Summary

Ref T10895. Currently, the "browse as a commit" code does these lookups, but the code can't be reused.

For T10895, I want to introduce "browse as revision", but it will need to do the same ref lookup. Separate this as a hardpoint so the code can be shared via hardpoint/ref infrastructure.

Test Plan

Ran arc browse master and similar commands.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:50 PM
This revision was automatically updated to reflect the committed changes.