Page MenuHomePhabricator

Adding ArcanistPythonImportsLinter
AbandonedPublic

Authored by justinlmeyer on Nov 23 2016, 9:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:07 AM
Unknown Object (File)
Sat, Mar 23, 3:58 PM
Unknown Object (File)
Jan 26 2024, 3:57 PM
Unknown Object (File)
Jan 24 2024, 2:38 AM
Unknown Object (File)
Dec 25 2023, 7:41 AM
Unknown Object (File)
Dec 24 2023, 4:23 PM
Unknown Object (File)
Dec 23 2023, 4:10 PM
Unknown Object (File)
Dec 15 2023, 3:16 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Would like to add this linter https://github.com/pinterest/arcanist-linters/blob/master/src/PythonImportsLinter.php which lints for illegal Python module imports.

Test Plan

arc unit

Diff Detail

Branch
python-imports-linter
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 14630
Build 19103: arc lint + arc unit

Unit TestsFailed

TimeTest
557 msArcanistFlake8LinterTestCase::Unknown Unit Message ("")
In 'undefined.lint-test', expected lint to raise error on line 3 at char 1, but no error was raised. Actually raised: No messages.
18 msArcanistChmodLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
0 msArcanistClosureLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msArcanistCpplintLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
16 msArcanistFilenameLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
View Full Test Results (1 Failed · 34 Passed · 25 Skipped)

Event Timeline

justinlmeyer retitled this revision from to Adding ArcanistPythonImportsLinter.
justinlmeyer updated this object.
justinlmeyer edited the test plan for this revision. (Show Details)
src/__phutil_library_map__.php
312

i modified this file manually, but looks like it should have been auto-generated. how do i generate this?

src/lint/linter/__tests__/python-imports/illegal_import.lint-test
3

i modified this file manually, but looks like it should have been auto-generated. how do i generate this?

oops, i dont think i meant to submit to this repo