Page MenuHomePhabricator

Remove "mysql.configuration-provider" configuration option
ClosedPublic

Authored by epriestley on Nov 22 2016, 12:36 PM.
Tags
None
Referenced Files
F14055460: D16911.diff
Sat, Nov 16, 12:14 PM
F14041292: D16911.diff
Mon, Nov 11, 5:12 PM
F14026316: D16911.diff
Fri, Nov 8, 12:58 AM
F14025244: D16911.id40713.diff
Thu, Nov 7, 3:31 PM
F14014188: D16911.diff
Sun, Nov 3, 12:51 AM
F13994894: D16911.id.diff
Wed, Oct 23, 9:12 AM
F13970648: D16911.diff
Oct 17 2024, 8:59 AM
F13968985: D16911.id40713.diff
Oct 16 2024, 11:49 PM
Subscribers
None

Details

Summary

Ref T11044. This was old Facebook cruft for reading configuration from SMC (and maybe doing some other questionable things). See D183.

(See also D175 for discussion of this from 2011.)

In modern Phabricator, you can subclass SiteConfig to provide dynamic configuration, and we do so in the Phacility cluster. This lets you change any config, and change in response to requests (e.g., for instancing) and is generally more powerful than this mechanism was.

This configuration provider theoretically let you roll your own replication or partitioning, but in practice I believe no one ever did, and no one ever could have anyway without more support in the upstream (for migrations, read-after-write, etc).

Test Plan
  • Grepped for removed option.
  • Browsed around with clustering off.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove "mysql.configuration-provider" configuration option.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 4:53 PM
This revision was automatically updated to reflect the committed changes.