Instead of adding the fileID to the metadata, could we just use the existing filePHID right next to it? This isn't a big deal, but it's a little redundant to pass them both around and if we want to do something in the future like let you click a macro or a Pholio thumbnail or Paste or whatever to bring up a lightbox with comments (or just render comments in this way in Phriction, which I think we do want) it will probably be easier if the code is PHID-based so it can work on objects other than files.

I think this is pre-existing, but I'd find it useful if there was a way to get to the /F123 page from the lightbox. Maybe we could link the monogram in the upper left?

The comments don't actually load for me locally in Safari, I just see this:

Maybe a Safari issue? I can dig into it if you can't reproduce.

Stuff you want for v0 is basically this, right?

• Some way to render these using Conpherence view code.
• Test for a timeline view being empty.

I ideally want this, too, but can counterdiff you when I have a chance:

• Convert Files to EditEngine (T11357).
• Serve this view from the standard EditEngine controller so any object can render this lightbox thread view.

I use ID in the header for F1234 as well. I hadn't thought about using this for Macro/Pholio. I planned to link the Monogram, like you mentioned. Is that possible with just a PHID?

You probably should just generate it on the server anyway and pass monogram or objectName or something anyway so we aren't duplicating the code for building monograms.

For v0 I just need is_empty I think. There is too much Conpherence UI specific stuff (date markers) in it for this. I did try to do all of this in PHUITimelineView, but had issues (500 server errors) when trying to pass in an extra parameter.

After edit-engine stuff... I can wire up actually posting from this form, I think.

I also want all files (not just viewable) to be comment-able, so I'd probably see if that's short and easy too. So if you upload an XLS file, even if we just show you a file icon, people could comment on it.

Subscribe button as well.

So yeah a few follow up diffs. I can repro Safari, but I'm not familiar with it's debugging tools, should be able to fix that though.

I think this ends up being fairly easy:

diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
index 6e27f85..5eaa528 100644
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -233,6 +233,10 @@ class PhabricatorApplicationTransactionView extends AphrontView {
     return $view;
   }
 
+  public function isTimelineEmpty() {
+    return !count($this->buildEvents(true));
+  }
+
   protected function getOrBuildEngine() {
     if (!$this->engine) {
       $field = PhabricatorApplicationTransactionComment::MARKUP_FIELD_COMMENT;

That's pretty inefficient, but should be fine for now to let this move forward.

I think I got all of your concerns?

I didn't add loading CSS but everything else is there.