Page MenuHomePhabricator
Differential D16892

Generate slightly shorter summaries in the typeahead browse dialog
ClosedPublic
Actions

Authored by epriestley on Nov 17 2016, 8:51 PM.
Tags
None
Referenced Files
F14347533: D16892.id40665.diff
Thu, Dec 19, 3:03 AM
F14347520: D16892.id40663.diff
Thu, Dec 19, 3:03 AM
F14347519: D16892.id.diff
Thu, Dec 19, 3:03 AM
F14347517: D16892.diff
Thu, Dec 19, 3:03 AM
Unknown Object (File)
Tue, Dec 17, 4:23 AM
Unknown Object (File)
Wed, Dec 11, 6:27 PM
Unknown Object (File)
Wed, Dec 11, 4:51 AM
Unknown Object (File)
Sun, Dec 8, 12:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier
Commits
rP79132311f409: Generate slightly shorter summaries in the typeahead browse dialog
Summary

Ref T11034. Try to produce a roughly-one-sentence summary instead of a roughly-one-paragraph summary for the browse dialog.

Test Plan
  • Added unit tests, ran unit tests.
  • Wrote a longer summary for a project, browsed to it, saw a shorter summary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40663.Nov 17 2016, 8:51 PM
epriestley retitled this revision from to Generate slightly shorter summaries in the typeahead browse dialog.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.
chad accepted this revision.Nov 17 2016, 9:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 9:05 PM
Closed by commit rP79132311f409: Generate slightly shorter summaries in the typeahead browse dialog (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2016, 9:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
project/
typeahead/
2 lines
infrastructure/
markup/
22 lines
__tests__/
43 lines

Diff 40665

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/__tests__/PhabricatorMarkupEngineTestCase.php

Loading...
Phabricator · Built by Phacility