Page MenuHomePhabricator

Make Calendar query for indirect invites/RSVPs by default, like Differential
ClosedPublic

Authored by epriestley on Nov 15 2016, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 5:11 AM
Unknown Object (File)
Sat, Jan 25, 8:03 PM
Unknown Object (File)
Tue, Jan 21, 11:54 AM
Unknown Object (File)
Tue, Jan 21, 10:21 AM
Unknown Object (File)
Fri, Jan 17, 12:28 PM
Unknown Object (File)
Fri, Jan 3, 6:03 AM
Unknown Object (File)
Tue, Dec 31, 6:39 PM
Unknown Object (File)
Dec 30 2024, 1:38 AM
Subscribers
None

Details

Summary

Ref T11816. Since the dashboard got updated, Differential now interprets "Responsible Users: epriestley" to mean "epriestley, or any project or package epriestley is part of". You can query for just "epriestley" with "exact(epriestley)".

Give Calendar invites the same behavior: "epriestley" means "any event epriestley is invited to, or a project they are a member of is invited to". Individual invites can be queried with "exact(epriestley)".

This is a little bit copy-pastey but I want to wait for a third use case to clean it up since I think I'm going to have to do a bunch of generalization around "how does an individual PHID get turned into a bunch of PHIDs".

Test Plan

Queried for "Invited: dog", "invited: viewer", "invited; exact(dog)", etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Calendar query for indirect invites/RSVPs by default, like Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php
15

O.o

This revision is now accepted and ready to land.Nov 15 2016, 8:29 PM

ya I'm being a lil' sneaky there <_<

Otherwise we'll get a bug report some day like "Uninstalling Differential prevents you from querying exact(epriestley) in Calendar".

This revision was automatically updated to reflect the committed changes.