Page MenuHomePhabricator

Make Calendar query for indirect invites/RSVPs by default, like Differential
ClosedPublic

Authored by epriestley on Nov 15 2016, 7:28 PM.
Tags
None
Referenced Files
F13060315: D16870.diff
Fri, Apr 19, 5:41 PM
Unknown Object (File)
Wed, Apr 17, 2:52 PM
Unknown Object (File)
Tue, Apr 9, 6:43 PM
Unknown Object (File)
Wed, Apr 3, 1:25 AM
Unknown Object (File)
Sun, Mar 31, 6:18 AM
Unknown Object (File)
Sun, Mar 31, 6:17 AM
Unknown Object (File)
Sun, Mar 31, 6:17 AM
Unknown Object (File)
Sat, Mar 30, 7:37 PM
Subscribers
None

Details

Summary

Ref T11816. Since the dashboard got updated, Differential now interprets "Responsible Users: epriestley" to mean "epriestley, or any project or package epriestley is part of". You can query for just "epriestley" with "exact(epriestley)".

Give Calendar invites the same behavior: "epriestley" means "any event epriestley is invited to, or a project they are a member of is invited to". Individual invites can be queried with "exact(epriestley)".

This is a little bit copy-pastey but I want to wait for a third use case to clean it up since I think I'm going to have to do a bunch of generalization around "how does an individual PHID get turned into a bunch of PHIDs".

Test Plan

Queried for "Invited: dog", "invited: viewer", "invited; exact(dog)", etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Calendar query for indirect invites/RSVPs by default, like Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php
15

O.o

This revision is now accepted and ready to land.Nov 15 2016, 8:29 PM

ya I'm being a lil' sneaky there <_<

Otherwise we'll get a bug report some day like "Uninstalling Differential prevents you from querying exact(epriestley) in Calendar".

This revision was automatically updated to reflect the committed changes.