Page MenuHomePhabricator

Make Calendar query for indirect invites/RSVPs by default, like Differential
ClosedPublic

Authored by epriestley on Nov 15 2016, 7:28 PM.
Tags
None
Referenced Files
F19303945: D16870.diff
Wed, Dec 24, 6:28 AM
F19077330: D16870.id40619.diff
Dec 1 2025, 2:54 PM
F18837302: D16870.id40623.diff
Oct 27 2025, 4:51 AM
F18819213: D16870.diff
Oct 22 2025, 5:02 AM
F18818134: D16870.id.diff
Oct 21 2025, 9:21 PM
F18672545: D16870.id.diff
Sep 25 2025, 7:43 AM
F18663615: D16870.diff
Sep 23 2025, 10:45 PM
F18595380: D16870.id.diff
Sep 12 2025, 9:29 PM
Subscribers
None

Details

Summary

Ref T11816. Since the dashboard got updated, Differential now interprets "Responsible Users: epriestley" to mean "epriestley, or any project or package epriestley is part of". You can query for just "epriestley" with "exact(epriestley)".

Give Calendar invites the same behavior: "epriestley" means "any event epriestley is invited to, or a project they are a member of is invited to". Individual invites can be queried with "exact(epriestley)".

This is a little bit copy-pastey but I want to wait for a third use case to clean it up since I think I'm going to have to do a bunch of generalization around "how does an individual PHID get turned into a bunch of PHIDs".

Test Plan

Queried for "Invited: dog", "invited: viewer", "invited; exact(dog)", etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Calendar query for indirect invites/RSVPs by default, like Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php
15

O.o

This revision is now accepted and ready to land.Nov 15 2016, 8:29 PM

ya I'm being a lil' sneaky there <_<

Otherwise we'll get a bug report some day like "Uninstalling Differential prevents you from querying exact(epriestley) in Calendar".

This revision was automatically updated to reflect the committed changes.