Differential D16807
Don't show "Limited" or "Test" translations unless an install is in developer mode Authored by epriestley on Nov 6 2016, 5:16 PM. Tags None Referenced Files
Subscribers None
Details
Ref T5267. Although translations with very few strings are already put into a "Limited Translations" group, this isn't necessarily clear and was empirically confusing to at least one user, who was surprised that selecting "Spanish" had no UI effect. Instead, hide limited and test translations entirely unless the install is in developer mode. In a non-developer-mode install, viewed translations menu. No longer saw translations with very few strings.
Diff Detail
Event TimelineComment Actions Maybe prototype is better? Does the limited test pass German or Chinese we have linked in the wiki? Comment Actions Both the German and Chinese translations have way more than enough strings to count as real translations, yeah. We could use prototype instead, but WMF has prototypes enabled so the option would still have shown up in the case from T5267. If we want to make these more discoverable, maybe I should just switch the label "Limited Translations" to something more scary, like "TRANSLATIONS THAT DO NOT WORK YET"? I can't really come up with a better label for this that accurately describes "translations with very few strings" succinctly, though. We could also split translations with zero strings into a separate group ("DEFINITELY NOT WORKING TRANSLATIONS") but that doesn't feel like a great fix and we have the same problem for translations with, like 1 or 2 strings. Or we could add a flag to translations like "Is this usable yet? / How usable is this?", but I think that makes providing translations trickier, and there's no single answer: Phabricator itself may be well-translated into, say, French, but some third-party application you install may provide a French translation that only has 2 strings. Maybe I can just ask on T5267. |