Page MenuHomePhabricator

On tasks, put Task Graph, Mocks and Mentions into a tabgroup
ClosedPublic

Authored by epriestley on Nov 6 2016, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 15, 9:39 PM
Unknown Object (File)
Tue, Nov 15, 6:28 AM
Unknown Object (File)
Fri, Nov 11, 10:50 PM
Unknown Object (File)
Fri, Nov 11, 12:15 AM
Unknown Object (File)
Fri, Nov 11, 12:14 AM
Unknown Object (File)
Fri, Nov 11, 12:14 AM
Unknown Object (File)
Fri, Nov 4, 8:25 PM
Unknown Object (File)
Fri, Nov 4, 12:16 AM
Subscribers
None
Tokens
"Love" token, awarded by johnny-bit.

Details

Summary

Fixes T4788. This change:

  • converts the "Task Graph" into a "Related Objects" tabgroup.
  • makes "Task Graph" the first tab in the group.
  • moves "Mocks" to become a tab.
  • adds a new "Mentions" tab, which shows inbound and outbound mentions.

Primary goal of "mocks" is to give us room for a pinboard/thumbnail view after the next Pholio iteration. Might make sense to make it the default tab (if present) at that point, too, since mocks are probably more important than related tasks when they're present.

Primary goal of "mentions" is to provide a bit of general support for various freeform relationships between tasks: if you want to treat tasks as "siblings" or "related" or "following" or whatever, you can at least find them all in one place. I don't plan to formalize any of these weird one-off relationships in the upstream, although it's vaguely possible that some far-future update might just let you define arbitrary custom relationships and then you can do whatever you want.

Test Plan

Screen Shot 2016-11-06 at 8.09.40 AM.png (174×1 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to On tasks, put Task Graph, Mocks and Mentions into a tabgroup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/controller/ManiphestTaskDetailController.php
475

I'll file something to keep track.

This revision is now accepted and ready to land.Nov 6 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.