Differential D16802

Allow users to mark themselves as "Available", "Busy" or "Away" while attending an event
ClosedPublic
Actions

Authored by epriestley on Nov 4 2016, 11:36 PM.

Tags

None

Referenced Files

	F14311897: D16802.id.diff
	Wed, Dec 18, 2:53 AM

	Unknown Object (File)
	Thu, Dec 12, 11:30 PM

	Unknown Object (File)
	Mon, Dec 9, 3:40 PM

	Unknown Object (File)
	Mon, Dec 9, 12:38 AM

	Unknown Object (File)
	Fri, Dec 6, 6:37 AM

	Unknown Object (File)
	Wed, Nov 27, 7:57 AM

	Unknown Object (File)
	Wed, Nov 27, 6:47 AM

	Unknown Object (File)
	Tue, Nov 19, 5:50 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rPe337029769ce: Allow users to mark themselves as "Available", "Busy" or "Away" while attending…

Summary

Now that we can do something meaningful with them, bring back the yellow dots for "busy".
Default to "busy" when attending events (we could make this "busy" for short events and "away" for long events or something).
Let users pick how to display their attending status on the event page.
Also show which event the user is attending since I had to mess with the cache code anyway. We can get rid of this again if it doesn't feel good.

Test Plan

Screen Shot 2016-11-04 at 4.33.07 PM.png (189×600 px, 23 KB)

Screen Shot 2016-11-04 at 4.33.04 PM.png (1×1 px, 183 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40464.Nov 4 2016, 11:36 PM

epriestley retitled this revision from to Allow users to mark themselves as "Available", "Busy" or "Away" while attending an event.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

chad accepted this revision.Nov 4 2016, 11:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2016, 11:46 PM

(Not married to this UI or anything, but it seemed to make sense to replace the "Join" / "Decline" buttons and was easy as a starting point.)

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 4 2016, 11:54 PM

Closed by commit rPe337029769ce: Allow users to mark themselves as "Available", "Busy" or "Away" while attending… (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 11:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20161104.calendar.01.availability.sql

2 lines

20161104.calendar.02.availdefault.sql

3 lines

src/

__phutil_library_map__.php

2 lines

applications/

calendar/

application/

PhabricatorCalendarApplication.php

2 lines

controller/

PhabricatorCalendarEventAvailabilityController.php

56 lines

PhabricatorCalendarEventViewController.php

37 lines

storage/

PhabricatorCalendarEvent.php

6 lines

PhabricatorCalendarEventInvitee.php

51 lines

view/

PHUIUserAvailabilityView.php

53 lines

people/

phid/

PhabricatorPeopleUserPHIDType.php

7 lines

query/

PhabricatorPeopleQuery.php

32 lines

storage/

PhabricatorUser.php

26 lines

Diff 40468

resources/sql/autopatches/20161104.calendar.01.availability.sql

Loading...

resources/sql/autopatches/20161104.calendar.02.availdefault.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventAvailabilityController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php

Loading...

src/applications/calendar/view/PHUIUserAvailabilityView.php

Loading...

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...