Page MenuHomePhabricator

Record a "series parent PHID" on Calendar events that retains relationships after forks
ClosedPublic

Authored by epriestley on Oct 31 2016, 8:54 PM.
Tags
None
Referenced Files
F15483167: D16780.id40418.diff
Wed, Apr 9, 10:22 AM
F15479468: D16780.id40408.diff
Tue, Apr 8, 7:29 AM
F15474884: D16780.id.diff
Sun, Apr 6, 1:08 PM
F15451412: D16780.diff
Fri, Mar 28, 9:58 PM
F15445960: D16780.id.diff
Thu, Mar 27, 4:45 PM
F15443892: D16780.id40418.diff
Thu, Mar 27, 6:46 AM
F15400174: D16780.id.diff
Mon, Mar 17, 10:06 AM
F15395626: D16780.diff
Sun, Mar 16, 8:33 AM
Subscribers
None

Details

Summary

When you edit "X and all future events", X becomes the new parent of an event series.

Currently, it loses its relationship to its original parent. Instead, retain that relationship -- it's separate from the normal "parent", but we can use it to make the UI more clear or tweak behaviors later.

This mostly just keeps us from losing/destroying data that we might need/want later.

Test Plan
  • Ran migrations.
  • Cancelled "X and all future events", saw sensible-appearing beahvior in the database for "seriesParentPHID".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Record a "series parent PHID" on Calendar events that retains relationships after forks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.