Page MenuHomePhabricator

Record a "series parent PHID" on Calendar events that retains relationships after forks
ClosedPublic

Authored by epriestley on Oct 31 2016, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 12:52 AM
Unknown Object (File)
Tue, Feb 18, 11:57 AM
Unknown Object (File)
Sun, Feb 9, 2:42 AM
Unknown Object (File)
Sun, Feb 9, 2:42 AM
Unknown Object (File)
Sun, Feb 9, 2:42 AM
Unknown Object (File)
Sun, Feb 9, 2:42 AM
Unknown Object (File)
Thu, Feb 6, 9:16 AM
Unknown Object (File)
Thu, Feb 6, 9:16 AM
Subscribers
None

Details

Summary

When you edit "X and all future events", X becomes the new parent of an event series.

Currently, it loses its relationship to its original parent. Instead, retain that relationship -- it's separate from the normal "parent", but we can use it to make the UI more clear or tweak behaviors later.

This mostly just keeps us from losing/destroying data that we might need/want later.

Test Plan
  • Ran migrations.
  • Cancelled "X and all future events", saw sensible-appearing beahvior in the database for "seriesParentPHID".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Record a "series parent PHID" on Calendar events that retains relationships after forks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.