Increase Conpherence notification panel transaction fetch
ClosedPublic
Actions

Authored by chad on Oct 12 2016, 4:09 PM.

Details

Reviewers

epriestley

Commits

rPea6db2ae9bf2: Increase Conpherence notification panel transaction fetch

Summary

We currently fetch 15 transactions for 5 rooms, which leads to some room subtitles in the notification panel to being blank since nothing was fetched. I don't think this is a great fix, but moves the bar much further. Maybe there is a more accurate fix that isn't 5 SQL queries?

Test Plan

Review notification panel in sandbox, ensure all threads have some additional information.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40190.Oct 12 2016, 4:09 PM

chad retitled this revision from to Increase Conpherence notification panel transaction fetch.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 12 2016, 4:09 PM

Yeah, this is garbage but fixing it isn't trivial. Best would probably be something like this:

Put a nullable lastInterestingTransactionPHID (or whatever, that name is kind of wordy) on ConpherenceThread.
When writing a transaction, update that field if it's an "interesting" transaction (I personally think only chat is interesting, but there's room for product debate on that).
Get rid of needTransactions(), replace it with needLastInterestingTransactions().
Do one query to load + attach those specific transactions by PHID.