Page MenuHomePhabricator

Clean up more Quicksand
ClosedPublic

Authored by chad on Oct 1 2016, 5:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 4:10 AM
Unknown Object (File)
Feb 16 2024, 4:10 AM
Unknown Object (File)
Feb 16 2024, 4:10 AM
Unknown Object (File)
Feb 8 2024, 12:16 PM
Unknown Object (File)
Jan 30 2024, 5:52 AM
Unknown Object (File)
Jan 24 2024, 5:19 AM
Unknown Object (File)
Dec 13 2023, 1:38 PM
Unknown Object (File)
Nov 30 2023, 6:14 AM
Subscribers

Details

Summary

Creates a background that renders inside the Quicksand frame, through sorcery.

Test Plan

Turn on Quicksand, visit lots of pages. See correct background colors. This probably blows something up I'm not testing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Clean up more Quicksand.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
webroot/rsrc/css/application/base/standard-page-view.css
20–31

whatcouldgowrong

When that background stuff breaks something I guess we can special case <body /> classes.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2016, 6:20 PM

it seemed pretty resilient, oddly, but still feels like it should break because CSS?

This revision was automatically updated to reflect the committed changes.