Page MenuHomePhabricator
Differential D16642

Clean up more Quicksand
ClosedPublic
Actions

Authored by chad on Oct 1 2016, 5:23 AM.
Tags
None
Referenced Files
F15469367: D16642.diff
Fri, Apr 4, 12:28 PM
F15464869: D16642.id40068.diff
Wed, Apr 2, 12:58 PM
F15457547: D16642.id40068.diff
Sun, Mar 30, 5:16 PM
F15457545: D16642.id40066.diff
Sun, Mar 30, 5:16 PM
F15457543: D16642.id40065.diff
Sun, Mar 30, 5:16 PM
F15457541: D16642.id40064.diff
Sun, Mar 30, 5:16 PM
F15457539: D16642.id.diff
Sun, Mar 30, 5:16 PM
F15446925: D16642.id.diff
Thu, Mar 27, 8:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP5eb4bc6ca960: Clean up more Quicksand
Summary

Creates a background that renders inside the Quicksand frame, through sorcery.

Test Plan

Turn on Quicksand, visit lots of pages. See correct background colors. This probably blows something up I'm not testing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40064.Oct 1 2016, 5:23 AM
chad retitled this revision from to Clean up more Quicksand.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 1 2016, 5:23 AM
chad updated this revision to Diff 40065.Oct 1 2016, 5:27 AM
  • bug with nav classes
chad updated this revision to Diff 40066.Oct 1 2016, 5:30 AM
  • workboard color
chad added inline comments.Oct 1 2016, 5:31 AM
webroot/rsrc/css/application/base/standard-page-view.css
20–31

whatcouldgowrong

epriestley edited edge metadata.Oct 1 2016, 6:20 PM

When that background stuff breaks something I guess we can special case <body /> classes.

epriestley accepted this revision.Oct 1 2016, 6:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2016, 6:20 PM
chad added a comment.Oct 1 2016, 6:21 PM

it seemed pretty resilient, oddly, but still feels like it should break because CSS?

Closed by commit rP5eb4bc6ca960: Clean up more Quicksand (authored by chad, committed by chad). · Explain WhyOct 1 2016, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40068

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigAllController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigApplicationController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigModuleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/search/application-search-view.css

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
Phabricator · Built by Phacility