The new markup made the keyboard shortcut help unhelpful, by making
the text white-on-light-grey. Zap the explicit colour setting.
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers
- open keyboard shortcut help: was white-on-light-grey, should be dark
- use ↓ in remarkup: was black-on-light-grey, remains same
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- upstream (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13791 Build 17818: Run Core Tests Build 17817: arc lint + arc unit
Event Timeline
Comment Actions
I think this was already fixed by D16568, although your base commit is ahead of that change -- I can't reproduce the white-on-grey in the "Keyboard Shortcuts" dialog issue at HEAD (after D16568, without this patch). Am I misunderstanding? Or did this just get rebased some time after the issue reproduced?
Comment Actions
(Compounding this problem, this install hasn't been updated to pick up that change yet, and is still behind D16568. I'll roll the secure tier in a bit.)
Comment Actions
Yep, my bad: I'd fixed it behind that commit, spotted the commits ahead before the rebase, but wasn't actually testing what I thought I was, so thought it was still there in master. (And sorry for the delay, was out all last week.)