Page MenuHomePhabricator
Differential D16567

Remove TYPE_FILES from Conpherence
ClosedPublic
Actions

Authored by chad on Sep 17 2016, 5:57 AM.
Tags
None
Referenced Files
F14370829: D16567.diff
Fri, Dec 20, 6:27 PM
Unknown Object (File)
Wed, Dec 18, 6:32 AM
Unknown Object (File)
Fri, Dec 13, 9:56 PM
Unknown Object (File)
Sat, Dec 7, 3:29 PM
Unknown Object (File)
Thu, Dec 5, 8:02 AM
Unknown Object (File)
Fri, Nov 29, 8:54 PM
Unknown Object (File)
Fri, Nov 29, 8:54 PM
Unknown Object (File)
Fri, Nov 29, 8:53 PM
View All Files
Subscribers
Korvin
Tokens
"Evil Spooky Haunted Tree" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
rPa2a19e29aace: Remove TYPE_FILES from Conpherence
Summary

I believe these are left over from widgets, when we added a "Files" widget that kept track of everything added to the window.

Test Plan

Added files to a Conpherece, Set an image when editing. Anything else?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39877.Sep 17 2016, 5:57 AM
chad retitled this revision from to Remove TYPE_FILES from Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 17 2016, 5:57 AM
epriestley accepted this revision.Sep 17 2016, 9:02 PM
epriestley edited edge metadata.

Nice!

This revision is now accepted and ready to land.Sep 17 2016, 9:02 PM
epriestley awarded a token.Sep 17 2016, 9:02 PM
Closed by commit rPa2a19e29aace: Remove TYPE_FILES from Conpherence (authored by chad, committed by chad). · Explain WhySep 17 2016, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39878

View Options

src/applications/conpherence/__tests__/ConpherenceRoomTestCase.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceTransaction.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
Phabricator · Built by Phacility