Conpherence JS package for celerity
ClosedPublic
Actions

Authored by chad on Sep 15 2016, 3:05 AM.

Details

Reviewers

epriestley

Commits

rPe75a20127a8e: Conpherence JS package for celerity

Summary

Bundles up 8 JS files

Test Plan

play with Conpherence

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39844.Sep 15 2016, 3:05 AM

chad retitled this revision from to Conpherence JS package for celerity.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 15 2016, 3:05 AM

epriestley accepted this revision.Sep 15 2016, 3:06 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 15 2016, 3:06 AM

Does this end up on every page because of durable-column? If so, it may be better to either leave that out or put everything in core.js.

Closed by commit rPe75a20127a8e: Conpherence JS package for celerity (authored by chad, committed by chad). · Explain WhySep 15 2016, 3:06 AM

This revision was automatically updated to reflect the committed changes.

(Or whatever.)

Oh.... uh...... we load durable column css and js every page anyways?

I see them in core... should I dump everything in core or just take out thread manager and durable column?

I think there's probably some significant room to be smarter about some of this stuff (we seem to be loading a Maniphest CSS package which has 41 lines of "Batch Edit" styles on the home page locally, for instance), but no real urgency. I can look at it at some point.