Page MenuHomePhabricator

Recover from a race when importing external objects (like JIRA issues) for the first time
ClosedPublic

Authored by epriestley on Sep 7 2016, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 5:18 AM
Unknown Object (File)
Sun, Apr 7, 1:05 PM
Unknown Object (File)
Thu, Mar 28, 8:33 PM
Unknown Object (File)
Thu, Mar 28, 3:27 AM
Unknown Object (File)
Mar 13 2024, 11:32 PM
Unknown Object (File)
Mar 12 2024, 8:24 PM
Unknown Object (File)
Jan 23 2024, 10:55 AM
Unknown Object (File)
Jan 19 2024, 8:51 PM
Subscribers
None

Details

Summary

Fixes T11604. If we send two requests to render a brand new tag at about the same time (say, 50ms apart) but JIRA takes more than 50ms to return from its API call, the two processes will race one another and try to save the same external object.

If they do, have whichever one lost the race just load the object the other one created.

Apply this to other bridges, too.

Test Plan
  • Created a new task in JIRA.
  • Referenced it for the first time in Differential, in a comment.
  • This causes two tag renders to fire. This might be a bug but I spend 30 seconds on it without figuring out what was up. Regardless, we should fix the race even if the reason it's triggering so easily legitimately is a bug.
  • Before patch: big error dialog (as in T11604).
  • After patch: smooth sailing.

Screen Shot 2016-09-07 at 10.45.55 AM.png (987×1 px, 198 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Recover from a race when importing external objects (like JIRA issues) for the first time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.