Page MenuHomePhabricator

Add a "--copy" flag to "bin/files migrate"
ClosedPublic

Authored by epriestley on Sep 6 2016, 2:37 PM.

Details

Summary

Ref T11596. When exporting data from the Phacility cluster, we bin/files migrate data from S3 into a database dump on the aux tier.

With current semantics, this moves the data and destroys it in S3.

Add a --copy flag to copy the data instead. This leaves the old copy around, which is what we want for exports.

Test Plan
  • Ran bin/files migrate to go from blob to disk with --copy. Verified a copy was left in the database.
  • Copied it back, verified a copy was left on disk (total: 2 database copies, 1 disk copy).
  • Moved it back without copy, verified database was destroyed and disk was created (total: 1 database copy, 2 disk copies).
  • Moved it back without copy, verified local disk was destroyed and blob was created (total: 2 datbabase copies, 1 disk copy).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Add a "--copy" flag to "bin/files migrate".Sep 6 2016, 2:37 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 39702.
chad edited edge metadata.Sep 6 2016, 8:01 PM
chad accepted this revision.
This revision is now accepted and ready to land.Sep 6 2016, 8:01 PM
This revision was automatically updated to reflect the committed changes.