Redesign Config Application
ClosedPublic
Actions

Authored by chad on Aug 29 2016, 9:01 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11132: New Phabricator NUX

Commits

rP60d1762a85ce: Redesign Config Application

Summary

Ref T11132, significantly cleans up the Config app, new layout, icons, spacing, etc. Some minor todos around re-designing "issues", mobile support, and maybe another pass at actual Group pages.

Test Plan

Visit and test every page in the config app, set new items, resolve setup issues, etc.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39616.Aug 29 2016, 9:01 PM

chad retitled this revision from to Redesign Config Application.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11132: New Phabricator NUX.

Owners added a subscriber: Restricted Owners Package.Aug 29 2016, 9:01 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 29 2016, 9:01 PM

Putting stuff like "Daemons" and "Access Logs" in "Developer Settings" seems questionable -- setting up a /var/log/phabricator/access.log or whatever doesn't seem related to developing Phabricator to me.
Not immediately obvious to me that sections are links? Probably obvious enough, but seems odd. e.g., on "Core Settings" there's a "Core Settings" header that's not a link, and then very similar looking link text which is a link.
Since there are no longer any sub headers, grouping of issues on "Setup Issues" is maybe a little pointless? Feels like random issues just have extra whitespace now.

Screen Shot 2016-08-29 at 2.14.23 PM.png (538×681 px, 88 KB)

Should we just nuke "Welcome / Installation Guide" at some point?

src/applications/config/module/PhabricatorConfigCollectorsModule.php
73–74	Unused.
webroot/rsrc/css/phui/phui-object-item-list-view.css
775–777	oh no where did the rules go

This revision is now accepted and ready to land.Aug 29 2016, 9:22 PM

epriestley awarded a token.Aug 29 2016, 9:22 PM

Any other ideas on segmenting these? I guess most don't feel "core" but maybe that's not actually a problem.

Maybe pull integrations out instead (AWS, Asana, mailgun, recaphca, sendgrid, phpmailer)?

Or do like a "Mail/Notifications" with Mailgun, Sendgrid, Mail, Notifications, PHPMailer, SMS?

[2016-08-29 22:37:13] EXCEPTION: (ArcanistDifferentialCommitMessageParserException) Error parsing field "Subscribers": The objects you have listed include objects which do not exist (PHID-OPKG-gm6ozazyms6q6i22gyam). at [<arcanist>/src/differential/ArcanistDifferentialCommitMessage.php:54]
arcanist(head=master, ref.master=9e82ef979e81), phabricator(head=rebuild-config, ref.master=00796e592b69, ref.rebuild-config=38d8cef759eb), phutil(head=master, ref.master=5fd1af8b4f2b)
  #0 ArcanistDifferentialCommitMessage::pullDataFromConduit(ConduitClient) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1795]
  #1 ArcanistDiffWorkflow::getCommitMessageFromRevision(string) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1527]
  #2 ArcanistDiffWorkflow::buildCommitMessage() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:469]
  #3 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]
chad@phac-dev:/var/www/html/dev/phabricator$ arc diff