Ref T11132. This gets rid of the red bar for admins and instead shows a new menu item next to notifications/chat if there are unresolved configuration issues. Menu goes away if there are no issues. May move this later into the bell icon, but think think might be the right place to start especially for NUX and updates. Maybe limit the number of items?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11132: New Phabricator NUX
- Commits
- rP00796e592b69: Move Setup Issues into it's own notification style menu
Tested with some, lots, and no config issues.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/view/page/menu/PhabricatorMainMenuView.php | ||
|---|---|---|
| 600 | derp. | |
Comment Actions
That countType thing is the only thing I see (and maybe colorize this again? I don't really feel strongly, but a lot of these issues are important, and this feels much less visible / attention-grabbing to me without color than the red bar did).
I think countType populates the little (3) in the page title. Not sure if these make sense to include, you could give them countType of null and then do something like this in aphlict-dropdown maybe:
+ if (config.countType) { JX.Title.setCount(config.countType, config.countNumber); + }
I think there are a couple of calls to JX.Title.setCount you'd need to tweak if you go that route.