Page MenuHomePhabricator

Make logic for streaming VCS stuff directly to Files more reusable
ClosedPublic

Authored by epriestley on Aug 26 2016, 3:14 PM.
Tags
None
Referenced Files
F14053376: D16458.diff
Fri, Nov 15, 3:10 PM
F14041011: D16458.diff
Mon, Nov 11, 3:05 PM
F14024791: D16458.diff
Thu, Nov 7, 12:21 PM
F13986637: D16458.id39588.diff
Mon, Oct 21, 4:29 AM
F13982631: D16458.diff
Sun, Oct 20, 12:46 AM
F13974749: D16458.diff
Oct 18 2024, 7:14 AM
F13960566: D16458.id.diff
Oct 15 2024, 12:05 AM
F13956745: D16458.id39598.diff
Oct 14 2024, 6:56 AM
Subscribers
None

Details

Summary

Ref T11524. Ref T10423. Earlier, I converted diffusion.filecontentquery to put the actual file content in Files, then return a PHID for the file, instead of trying to send the content over Conduit.

In T11524, we have a similar set of problems with diffs that contain non-UTF8 data (and, in T10423, diffs that are simply enormous).

I want to provide an API method to do the same sort of thing with diff output (like from git diff), so we call the method, it shoves the data in Files, and then we go pull it out of Files.

To support this, take the "shove the output of a Future into Files" logic and put it in a new base FileFuture query. This will let me make RawDiffQuery share the logic more easily.

Test Plan

Browsed Diffusion, ran diffusion.filecontentquery to fetch file content.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make logic for streaming VCS stuff directly to Files more reusable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2016, 4:02 PM
This revision was automatically updated to reflect the committed changes.