Page MenuHomePhabricator

Fix handling of View Policy in CLI upload workflow for small, unique files
ClosedPublic

Authored by epriestley on Aug 17 2016, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 2, 8:00 PM
Unknown Object (File)
Thu, Mar 28, 9:52 PM
Unknown Object (File)
Thu, Mar 28, 8:11 PM
Unknown Object (File)
Thu, Mar 28, 6:00 PM
Unknown Object (File)
Mon, Mar 25, 6:35 PM
Unknown Object (File)
Mar 5 2024, 11:36 AM
Unknown Object (File)
Mar 4 2024, 3:08 PM
Unknown Object (File)
Feb 14 2024, 2:00 PM
Subscribers
None

Details

Summary

Ref T7148. When uploading files from the CLI with a particular view policy, we may not respect it if the file is unique (so the data isn't already known) and small (so it doesn't invoke the chunker).

This is rare (and may never have happened outside of testing) because:

  • production dumps are always larger than the minimum chunk size;
  • only cluster stuff uses setViewPolicy();
  • the default policy is "Administrators" anyway, which is safe.

However, I caught it in local testing, so fix it up.

Test Plan

Used bin/host upload --file ... to upload a small, unique file. Verified it uploaded with the correct custom view policy ("No One") rather than the default view policy ("Administrators").

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix handling of View Policy in CLI upload workflow for small, unique files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2016, 3:44 PM
This revision was automatically updated to reflect the committed changes.