Page MenuHomePhabricator
Differential D16403

Update Preamble documentation for clusters with mixed request sources and loadbalancer chains
ClosedPublic
Actions

Authored by epriestley on Aug 16 2016, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 3:44 PM
Unknown Object (File)
Wed, Apr 17, 2:35 PM
Unknown Object (File)
Thu, Apr 11, 6:59 AM
Unknown Object (File)
Tue, Apr 9, 12:45 AM
Unknown Object (File)
Thu, Apr 4, 1:26 AM
Unknown Object (File)
Sun, Mar 31, 10:05 PM
Unknown Object (File)
Fri, Mar 29, 11:28 PM
Unknown Object (File)
Fri, Mar 29, 6:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11487: Update preamble documentation to consider cluster mode and loadbalancers in series
Commits
rPa35b03ac6ad9: Update Preamble documentation for clusters with mixed request sources and…
Summary

Fixes T11487. Improve documentation for three situations:

  • When you configure a cluster behind a load balancer, all requests are trusted but not all have an "X-Forwarded-For" header. Change the suggested snippet to read this header only if it exists.
  • When a request goes through a series of load balancers (as with a CDN) they can end up writing a list of IPs to the header. Parse these.
  • Remove the "rate limiting" stuff -- this got disabled/removed a long time ago and is misleading/incorrect.
Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39445.Aug 16 2016, 10:49 PM
epriestley updated this revision to Diff 39446.
epriestley retitled this revision from to Update Preamble documentation for clusters with mixed request sources and loadbalancer chains.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11487: Update preamble documentation to consider cluster mode and loadbalancers in series.
  • Add the other half of a missing sentence
chad accepted this revision.Aug 16 2016, 11:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2016, 11:05 PM
Closed by commit rPa35b03ac6ad9: Update Preamble documentation for clusters with mixed request sources and… (authored by epriestley, committed by epriestley). · Explain WhyAug 16 2016, 11:05 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D17758: Update rate limiting for APCu and X-Forwarded-For.Apr 21 2017, 8:59 PM
epriestley mentioned this in rP3698e4a14f6c: Update rate limiting for APCu and X-Forwarded-For.Apr 22 2017, 3:39 AM

Revision Contents
Changeset List

PathSize
src/
docs/
user/
configuration/
85 lines

Diff 39450

View Options

src/docs/user/configuration/configuring_preamble.diviner

Loading...
Phabricator · Built by Phacility