Page MenuHomePhabricator

Update Preamble documentation for clusters with mixed request sources and loadbalancer chains
ClosedPublic

Authored by epriestley on Aug 16 2016, 10:49 PM.
Tags
None
Referenced Files
F14031879: D16403.diff
Sat, Nov 9, 12:08 PM
F14017114: D16403.id39445.diff
Mon, Nov 4, 2:20 PM
F13999112: D16403.id.diff
Thu, Oct 24, 12:55 PM
F13986287: D16403.diff
Mon, Oct 21, 1:48 AM
F13965710: D16403.id39450.diff
Oct 16 2024, 3:52 AM
F13955918: D16403.id39445.diff
Oct 14 2024, 3:33 AM
Unknown Object (File)
Oct 10 2024, 1:06 PM
Unknown Object (File)
Oct 10 2024, 1:06 PM
Subscribers
None

Details

Summary

Fixes T11487. Improve documentation for three situations:

  • When you configure a cluster behind a load balancer, all requests are trusted but not all have an "X-Forwarded-For" header. Change the suggested snippet to read this header only if it exists.
  • When a request goes through a series of load balancers (as with a CDN) they can end up writing a list of IPs to the header. Parse these.
  • Remove the "rate limiting" stuff -- this got disabled/removed a long time ago and is misleading/incorrect.
Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39446.
epriestley retitled this revision from to Update Preamble documentation for clusters with mixed request sources and loadbalancer chains.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Add the other half of a missing sentence
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2016, 11:05 PM
This revision was automatically updated to reflect the committed changes.