Page MenuHomePhabricator

Provide a link to parent/child tasks as a search result from task graphs
ClosedPublic

Authored by epriestley on Jul 28 2016, 8:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 2, 8:18 PM
Unknown Object (File)
Thu, Mar 28, 3:47 PM
Unknown Object (File)
Feb 18 2024, 10:50 AM
Unknown Object (File)
Feb 18 2024, 10:50 AM
Unknown Object (File)
Feb 18 2024, 10:50 AM
Unknown Object (File)
Feb 12 2024, 12:02 AM
Unknown Object (File)
Feb 3 2024, 11:31 AM
Unknown Object (File)
Jan 18 2024, 10:08 AM
Subscribers
None

Details

Summary

Ref T4788. Add links to jump to search results with a task's parents or subtasks. This allows relationships to remain useful if there are a zillion of them, and you can sort/filter stuff more easily.

Language might need some tweaking at some point, feeling a little un-brainy today with wordstuff.

Test Plan

Screen Shot 2016-07-28 at 1.26.24 PM.png (802×1 px, 156 KB)

Screen Shot 2016-07-28 at 1.26.31 PM.png (802×1 px, 138 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a link to parent/child tasks as a search result from task graphs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Think I'll need to design a more subtle button for this treatment.

This revision is now accepted and ready to land.Jul 28 2016, 8:33 PM

It also might not be terrible to make the empty state two big "View Subtasks" and "View Parent Tasks" buttons, but I don't think we have any similar elements anywhere and suspect that would look bizarre if I cobbled it together:

+--------------------------------------------------+
| Task Graph                      [ .o Search... ] |
+--------------------------------------------------+
| There are too many tasks, but you can [ View     |
| Subtasks ] or [ View Parent Tasks ] if you want! |
+--------------------------------------------------+

I suppose I could just link them if I really get excited about building this.

This revision was automatically updated to reflect the committed changes.

dunno, never felt the need to search from inside here.

Yeah, I think it's mostly for the "we linked 235 tasks, for GREAT reasons which are SECRET which we CAN NEVER TELL YOU" cases from T4788, where the task is really being used like a tag. "Search Subtasks" is really, like "Search For Tasks Tagged With This Task", I guess. I think this is the best/most reasonable thing we can do if a task has 200 subtasks, and it didn't take too much work to build, I just haven't seen any really good use cases for doing this. Not too inclined to spend much effort chasing this down since I think our behavior is reasonable now and the use case isn't too compelling.