Page MenuHomePhabricator

Clean up recurring event information on Calendar events
ClosedPublic

Authored by epriestley on Jul 28 2016, 2:55 PM.

Details

Summary

Ref T11326. This adds prev/next links for recurring events (ala D16179) and moves the "accept/decline" buttons closer to the invite list. This might need some fiddling, but should be a little more human-friendly.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 39293.Jul 28 2016, 2:55 PM
epriestley retitled this revision from to Clean up recurring event information on Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jul 28 2016, 4:11 PM
chad edited edge metadata.

Maybe move [ Accept ] [ Decline ] into the main header?

This revision is now accepted and ready to land.Jul 28 2016, 4:11 PM

I moved them out of the main header in this diff (putting them closer to the invite list) since they felt kind of weird to me up there, but I can put them back. I'm not really sure we need them.

chad added a comment.Jul 28 2016, 5:03 PM

Is this an event you've been invited to? Or just an event you happen to see? I expect if I'm invited, the actions are more prominent. If it it's just some random event, then maybe just a join button? I haven't played with these much yet.

The big action buttons only show up if you have an unresponded invite.

There are normal ways to interact with invite status in the standard action list (e.g., "Decline Event") to an event you previously marked yourself attending.

chad added a comment.Jul 28 2016, 5:22 PM

Yeah sorry, I slightly prefer them in the header now that I've had some caffeine. :(

Haha, no problem. I expect a lot of Calendar stuff to need a few more UI iterations, I'm just trying to move things somewhere in the right direction and get the backend kind of reasonably well organized for now.

The buttons feel weird in this diff to me too, just also weird in the other spot. ¯\_(ツ)_/¯

epriestley updated this revision to Diff 39296.Jul 28 2016, 5:56 PM
epriestley edited edge metadata.
  • Put the buttons back in the header.
This revision was automatically updated to reflect the committed changes.