Page MenuHomePhabricator
Differential D16336

Give Calendar days from adjacent months a background color hint
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 2:25 PM.
Tags
None
Referenced Files
F15449867: D16336.id39281.diff
Fri, Mar 28, 12:34 PM
F15445153: D16336.id.diff
Thu, Mar 27, 12:36 PM
F15438288: D16336.diff
Wed, Mar 26, 12:00 AM
F15435693: D16336.diff
Tue, Mar 25, 9:47 AM
F15432508: D16336.id39274.diff
Mon, Mar 24, 6:23 PM
F15432418: D16336.diff
Mon, Mar 24, 6:03 PM
F15425241: D16336.id39274.diff
Sun, Mar 23, 3:27 AM
F15395815: D16336.diff
Sun, Mar 16, 9:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rP89f6764e1bdb: Give Calendar days from adjacent months a background color hint
Summary

Ref T11326. When viewing "February", add a class to dates in January and March to let them be styled a little differently as a UI hint.

For now, I've given them a grey background. (Calendar.app changes the date number color instead.)

Test Plan

Screen Shot 2016-07-27 at 7.22.51 AM.png (1×1 px, 257 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39274.Jul 27 2016, 2:25 PM
epriestley retitled this revision from to Give Calendar days from adjacent months a background color hint.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 2:25 PM
chad accepted this revision.Jul 27 2016, 4:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 4:03 PM
Closed by commit rP89f6764e1bdb: Give Calendar days from adjacent months a background color hint (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
12 lines
webroot/
rsrc/
css/
phui/
calendar/
4 lines

Diff 39281

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility