Page MenuHomePhabricator
Differential D16335

Remove extra margins on Calendar month view
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:06 AM
Unknown Object (File)
Fri, Apr 19, 5:07 PM
Unknown Object (File)
Fri, Apr 12, 11:25 PM
Unknown Object (File)
Thu, Apr 11, 7:10 AM
Unknown Object (File)
Sun, Apr 7, 5:18 PM
Unknown Object (File)
Wed, Apr 3, 1:16 AM
Unknown Object (File)
Mar 22 2024, 8:50 PM
Unknown Object (File)
Mar 21 2024, 6:45 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rPba00022730c7: Remove extra margins on Calendar month view
Summary

Ref T11326. This doesn't go quite as far as the mock in T11326#185932, but gets rid of the easy margins.

Also cleans up some of the border rules so they're simpler and more consistent (no weird ragged edges on the far right).

Test Plan

Screen Shot 2016-07-27 at 6.58.15 AM.png (1×1 px, 207 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39273.Jul 27 2016, 2:01 PM
epriestley retitled this revision from to Remove extra margins on Calendar month view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 2:01 PM
chad accepted this revision.Jul 27 2016, 4:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 4:02 PM
Closed by commit rPba00022730c7: Remove extra margins on Calendar month view (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
calendar/
query/
19 lines
search/
view/
4 lines
webroot/
rsrc/
css/
phui/
calendar/
15 lines

Diff 39280

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/search/view/PhabricatorApplicationSearchResultView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility